Revert "optimization: txpool pending cache improvement (#177)" #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prepare for v0.5.2 release
prepare for v0.5.3 release
prepare for v0.5.4 release
This reverts commit 4ccfc35.
bnoieh
approved these changes
Jan 4, 2025
|
This PR is relied on and included by #244 , so we drop it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The improvement of #177 saves about 50+ms of calling txpool.Pending() for the miner, when the pending transactions accumulate up to 100k+.
The improvement of performance depends on the number of pending list.
However, after we had resolved other bottlenecks, the pending transactions will usually be under 100k+, which means it can't save more than 50+ms, and besides, it changes a lot of code to get the improvement.
So we decided to revert it and make it a draft, to re-enable it in the future when needed.