Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feats: init payment module #5
feats: init payment module #5
Changes from 55 commits
b9d805f
c2c1728
7282513
f3bb180
b4d6b0d
cd03a26
36a1b18
59c09a9
62fddfd
bac8f28
24dc3f7
94948bd
d76b0bc
ff73f83
c77cfc4
fa2f508
2676b2f
ab6a4b4
60667b0
142ba1f
59ad60e
2b8bfbd
bf10273
ccc8ad3
7fc5618
bb36034
ebc70bd
99eb3cf
1b88d61
59a747e
542fb71
9743684
41e7bb9
9480d6f
c492664
6d41f7e
df0cd3c
4aa8b98
f15fda0
242b480
e553690
c86ba68
185cb2a
7f1a80c
4100f90
c91a5dc
a370e3b
5816995
663e9df
8b84612
4779266
fbc18e3
b3bd2a7
c2f870c
d69abf3
b6b6551
922ddaa
6b79240
74b5ec5
53c282b
f08cfc1
f1b53a4
27bb584
4e20824
67eff6a
de12c9c
3574649
18e3e43
afc3cb3
6d60051
8b954d8
4aa9d1c
0ccd344
487227a
d22aa67
d6aca21
e376401
8038a4c
097caff
2446428
890c06f
8215465
85619fa
da27d14
f204b23
e449369
c176cf3
ebf9fd1
9bba57b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any pattern to follow, since some
NewKeeper
return pointer, some return structure.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the original keepers are structures, and the keepers generated by ignite are pointers.
I checked the usage of ignite generated
NewKeeper
, it's only used inapp.go
and test utils. It should be fine to change the return value to structure style. We can submit another refactor PR to change all this later.