Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feats: init payment module #5

Merged
merged 89 commits into from
Feb 9, 2023
Merged

feats: init payment module #5

merged 89 commits into from
Feb 9, 2023

Conversation

owen-reorg
Copy link
Contributor

@owen-reorg owen-reorg commented Nov 24, 2022 •
edited
Loading

Description

Payment Module Design: https://github.com/bnb-chain/greenfield-whitepaper/blob/main/part3.md#21-billing-and-payment

TODOs

  • remove the mock messages after integrating with the storage module
  • add more price change test cases
  • rewrite the end-to-end test when the go-sdk is ready

@owen-reorg owen-reorg changed the title [r4r] init payment module init payment module Nov 24, 2022
@owen-reorg owen-reorg added the r4r label Nov 24, 2022
keefel
keefel reviewed Nov 24, 2022
View reviewed changes
proto/bfs/payment/query.proto Outdated Show resolved Hide resolved
proto/bfs/payment/query.proto Outdated Show resolved Hide resolved
proto/bfs/payment/query.proto Outdated Show resolved Hide resolved
@unclezoro unclezoro marked this pull request as draft November 25, 2022 06:46
@unclezoro
Copy link
Collaborator

I mark the PR as a draft, please write a detailed description about this PR and try refine the title.

@owen-reorg owen-reorg marked this pull request as ready for review February 3, 2023 07:30
@unclezoro unclezoro merged commit 569f459 into develop Feb 9, 2023
This was referenced Feb 10, 2023
Merged
Merged
@unclezoro unclezoro deleted the init-payment branch April 18, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keefel keefel keefel approved these changes

@j75689 j75689 j75689 approved these changes

@fynnss fynnss fynnss approved these changes

@unclezoro unclezoro unclezoro approved these changes

@yutianwu yutianwu yutianwu approved these changes

Assignees
No one assigned
Labels
r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@owen-reorg @unclezoro @yutianwu @fynnss @j75689 @keefel