Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): migrate to eslint-plugin-n@17.11.1 #540

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

MikeMcC399
Copy link
Contributor

Issue

The current configuration includes eslint-plugin-node@11.1.0, released in March 2020. Its README text says:

This project has been no longer maintained. Please consider to use https://github.com/eslint-community/eslint-plugin-n.

https://github.com/eslint-community/eslint-plugin-n is a fork of the discontinued eslint-plugin-node, providing version continuity.

Flat configuration support requires a minimum eslint-plugin-n@16.1.0.

eslint-plugin-n@latest is currently eslint-plugin-n@17.11.1 constrained to "node": "^18.18.0 || ^20.9.0 || >=21.1.0"

Change

Replace eslint-plugin-node@11.1.0 with eslint-plugin-n@latest which is currently eslint-plugin-n@17.11.1.

Verification

On Ubuntu 24.04.1 LTS, Node.js 18.20.4

git clean -xfd
npm ci
npm run lint
npm test

Ignore warnings from npm ci:

npm warn deprecated @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs
npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.

Confirm no errors and no uncommitted changes.

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399 MikeMcC399 force-pushed the migrate/eslint-plugin-node branch from c3b6802 to a54fc13 Compare October 23, 2024 09:45
@MikeMcC399 MikeMcC399 changed the title Migrate from eslint-plugin-node to eslint-plugin-n@17.11.1 chore(deps): migrate to eslint-plugin-n@17.11.1 Oct 23, 2024
@MikeMcC399 MikeMcC399 force-pushed the migrate/eslint-plugin-node branch 2 times, most recently from 599ceeb to 01a9ef8 Compare October 23, 2024 09:47
@MikeMcC399 MikeMcC399 changed the title chore(deps): migrate to eslint-plugin-n@17.11.1 chore(deps): migrate to eslint-plugin-n@17.11.1 Oct 23, 2024
@ddzz
Copy link
Collaborator

ddzz commented Oct 23, 2024

@MikeMcC399 can you fix the merge conflicts so I can merge this? Thanks again for all your work here.

@ddzz ddzz requested a review from bmish October 23, 2024 12:50
@MikeMcC399
Copy link
Contributor Author

@ddzz

  • Unfortunately in the interim PR chore(deps-dev): Bump markdownlint-cli from 0.32.2 to 0.42.0 #532 has caused an issue with engine Node.js 18 compatibility, so I would need the problematic PR reverting before I rebase on the main branch.
  • I will put any PRs that I would like reviewed and merged out of Draft state, so you can assume if any of mine are still in Draft, then I'm not expecting them to be ready for merge.

@ddzz
Copy link
Collaborator

ddzz commented Oct 23, 2024

markdownlint-cli PR has been reverted.

Migrate from eslint-plugin-node to eslint-plugin-n@17.11.1
@MikeMcC399 MikeMcC399 force-pushed the migrate/eslint-plugin-node branch from 93fba16 to 3bdc87c Compare October 23, 2024 14:33
@MikeMcC399
Copy link
Contributor Author

@ddzz

Rebased and conflicts are fixed.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 23, 2024 14:37
@ddzz ddzz merged commit 6b05e48 into bmish:main Oct 23, 2024
2 checks passed
@MikeMcC399 MikeMcC399 deleted the migrate/eslint-plugin-node branch October 23, 2024 14:47
@bmish bmish added the internal label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants