Skip to content

Commit

Permalink
chore(deps): migrate to eslint-plugin-n@17.11.1
Browse files Browse the repository at this point in the history
Migrate from `eslint-plugin-node` to `eslint-plugin-n@17.11.1`
  • Loading branch information
MikeMcC399 committed Oct 23, 2024
1 parent bac3183 commit 599ceeb
Show file tree
Hide file tree
Showing 5 changed files with 257 additions and 115 deletions.
5 changes: 2 additions & 3 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = {
sourceType: 'module',
},
extends: [
'plugin:node/recommended',
'plugin:n/recommended',
'plugin:unicorn/recommended', // Turn eslint-plugin-unicorn recommended rules on again because many were turned off by eslint-plugin-square.
'plugin:jest/recommended',
],
Expand All @@ -30,7 +30,6 @@ module.exports = {
'import/no-named-as-default-member': 'off',

'import/extensions': ['error', 'always'],
'node/no-missing-import': 'off', // Disabled due to a bug: https://github.com/mysticatea/eslint-plugin-node/issues/342
'unicorn/expiring-todo-comments': 'off',
'unicorn/no-array-reduce': 'off',
'unicorn/no-nested-ternary': 'off',
Expand All @@ -50,7 +49,7 @@ module.exports = {
'plugin:@typescript-eslint/recommended-requiring-type-checking',
],
rules: {
'node/no-unsupported-features/es-syntax': [
'n/no-unsupported-features/es-syntax': [
'error',
{ ignores: ['dynamicImport', 'modules'] },
],
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
runs-on: ${{ matrix.os }}-latest

strategy:
fail-fast: false
matrix:
os: [ ubuntu, windows ]
node-version: [14.x, 16.x, 18.x]
Expand Down
5 changes: 4 additions & 1 deletion bin/eslint-doc-generator.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#!/usr/bin/env node
/* eslint node/shebang:"off" -- shebang needed so compiled code gets interpreted as JS */
/* eslint n/hashbang:"off" -- shebang needed so compiled code gets interpreted as JS */
//
// rule was renamed in https://github.com/eslint-community/eslint-plugin-n/releases/tag/v17.0.0
// from n/shebang to n/hashbang

import { run } from '../lib/cli.js';
import { generate } from '../lib/generator.js';
Expand Down
Loading

0 comments on commit 599ceeb

Please sign in to comment.