Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate drawer menu on mobile web #7711

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Animate drawer menu on mobile web #7711

merged 3 commits into from
Feb 12, 2025

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Feb 10, 2025

Based on #7704

Animates both ways. Animating in uses an exponential easing function

Screen.Recording.2025-02-10.at.16.05.52.mov

Copy link

github-actions bot commented Feb 10, 2025

Old size New size Diff
7.02 MB 7.02 MB 21 B (0.00%)

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one nit if you're able to fix it

dark: 'rgba(1, 82, 168, 0.1)',
dim: 'rgba(10, 13, 16, 0.8)',
})
: 'transparent',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing the fade out, but not fade in. Maybe it doesn't like the transition from transparent to a defined color? Not sure tbh, css transitions are finicky with newly rendered content iirc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha I was hoping you wouldn't spot it - yeah, it's a transition rather than an animation, so the nothing -> color doesn't animate. Fixing this would require messing with the HTML structure which I was hoping to avoid

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe. Does it not work going from rgba(0,0,0,0) to the rgba values defined for the open state?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'd need to render it once with that value, then on next tick change it again. totally doable but very messy!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yeah that's what I was afraid of. LGTM, still net positive 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can come back to it!

@mozzius mozzius force-pushed the samuel/animate-drawer branch from f722a64 to 92efa05 Compare February 12, 2025 21:21
@arcalinea arcalinea temporarily deployed to samuel/animate-drawer - social-app PR #7711 February 12, 2025 21:21 — with Render Destroyed
@mozzius mozzius merged commit 1a3ecdf into main Feb 12, 2025
7 checks passed
@mozzius mozzius deleted the samuel/animate-drawer branch February 12, 2025 21:51
estrattonbailey added a commit that referenced this pull request Feb 13, 2025
* origin/main: (39 commits)
  Revert "fix quote & feed padding not being pressable (#7694)" (#7733)
  Nightly source-language update
  Add dev mode for easy copying of at:// URIs and DIDs (#7723)
  Improved search language select (#7591)
  Improved search page (#7590)
  Animate drawer menu on mobile web (#7711)
  Special treatment for recommended starter packs (#7706)
  invert new postonboarding gate (#7695)
  Animate dropdown menus (#7704)
  Better animations for dialogs, animate web composer (#7703)
  fix quote & feed padding not being pressable (#7694)
  ungate trending (#7696)
  run prettier (#7727)
  Nightly source-language update
  Add deploy key to nightly commit (#7722)
  [APP-1031] Add new followerRule to threadgate settings (#7681)
  Fix bug in GH action nightly-update-source-languages.yaml
  More i18n process updates (#7720)
  Run intl:extract on english to see if crowdin picks up on the changes
  Refine accessibilityHint (#7554)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants