Better animations for dialogs, animate web composer #7703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
samuel/zoom-in-modals - social-app PR #7703
Render
Destroyed
|
arcalinea
temporarily deployed
to
samuel/zoom-in-modals - social-app PR #7703
Render
Destroyed
Merged
arcalinea
temporarily deployed
to
samuel/zoom-in-modals - social-app PR #7703
Render
Destroyed
estrattonbailey
approved these changes
Feb 12, 2025
estrattonbailey
added a commit
that referenced
this pull request
Feb 13, 2025
* origin/main: (39 commits) Revert "fix quote & feed padding not being pressable (#7694)" (#7733) Nightly source-language update Add dev mode for easy copying of at:// URIs and DIDs (#7723) Improved search language select (#7591) Improved search page (#7590) Animate drawer menu on mobile web (#7711) Special treatment for recommended starter packs (#7706) invert new postonboarding gate (#7695) Animate dropdown menus (#7704) Better animations for dialogs, animate web composer (#7703) fix quote & feed padding not being pressable (#7694) ungate trending (#7696) run prettier (#7727) Nightly source-language update Add deploy key to nightly commit (#7722) [APP-1031] Add new followerRule to threadgate settings (#7681) Fix bug in GH action nightly-update-source-languages.yaml More i18n process updates (#7720) Run intl:extract on english to see if crowdin picks up on the changes Refine accessibilityHint (#7554) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new animation atoms with some preset animations, and animates dialogs (including the composer) with a combined fade/zoom animation. Respects prefers-reduced-motion
It'd be nice to have exit animations on these, but the elements are unmounted on hide so would require deeper reworking to get that functional
Screen.Recording.2025-02-08.at.18.34.43.mov
Test plan
Test different browsers, check that all the animations look good and don't impede functionality