Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing error after playing music several times with AudioCache #844

Merged
merged 2 commits into from
Apr 11, 2021
Merged

Fixing error after playing music several times with AudioCache #844

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39e721f
Fixing error after playing music several times with AudioCache
wenxiangjiang Apr 10, 2021
4775b8e
fix playBytes
wenxiangjiang Apr 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- Refactor Notifications code (small breaking changes)
- AudioCache for web
- Fixing basic features for Android lower than API 23
- Fixing error after playing music several times with AudioCache

## 0.18.3
- Fix Float vs Double mixup on Swift that prevent non-integer values for volume/playback
Expand Down
4 changes: 3 additions & 1 deletion lib/audio_cache.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ class AudioCache {
}) async {
final uri = await load(fileName);
final player = _player(mode);
player.setReleaseMode(ReleaseMode.STOP);
if (fixedPlayer != null) {
player.setReleaseMode(ReleaseMode.STOP);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we set it to RELEASE?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait RELEASE is already the default right? for new players

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can just remove this entirely. but the if is definitely an improvement!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luanpotter Yes, RELEASE is the default. the if is directed at #618

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either RELEASE or STOP can solve the issue, but I think STOP may be better.

}
await player.play(
uri.toString(),
volume: volume,
Expand Down