Fixing error after playing music several times with AudioCache #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
reviewed
Apr 10, 2021
| @@ -158,7 +158,9 @@ class AudioCache { | |||
| }) async { | |||
| final uri = await load(fileName); | |||
| final player = _player(mode); | |||
| player.setReleaseMode(ReleaseMode.STOP); | |||
| if (fixedPlayer != null) { | |||
| player.setReleaseMode(ReleaseMode.STOP); | |||
There was a problem hiding this comment.
should we set it to RELEASE?
There was a problem hiding this comment.
wait RELEASE is already the default right? for new players
There was a problem hiding this comment.
maybe we can just remove this entirely. but the if is definitely an improvement!
There was a problem hiding this comment.
@luanpotter Yes, RELEASE is the default. the if is directed at #618
There was a problem hiding this comment.
Either RELEASE or STOP can solve the issue, but I think STOP may be better.
|
I think |
wenxiangjiang
deleted the
843-fix-error-after-playing-music-several-times
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes #843