Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: address karma issues with Chrome v128 #2690

Closed
wants to merge 2 commits into from
Closed

ci: address karma issues with Chrome v128 #2690

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22eb989
ci: address karma issues with Chrome v128
Blackbaud-SteveBrush Sep 5, 2024
1385a46
Merge branch '10.x.x' into fix-karma
johnhwhite Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ module.exports = () => {
},
],
customLaunchers: {
ChromeDesktop: {
base: 'Chrome',
flags: ['--window-size=1920,1080'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added to address the issues we were seeing with the SkyScrollShadowDirective tests. If you want to run the debugger (watch mode) locally, run npx nx test core --browsers=ChromeDesktop.

},
ChromeHeadlessNoSandbox: {
base: 'ChromeHeadless',
flags: [
Expand All @@ -52,7 +56,6 @@ module.exports = () => {
jasmine: {
random: false,
},
clearContext: false, // leave Jasmine Spec Runner output visible in browser
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this configuration to address the "Some of your tests did a full page reload!" error introduced in Chrome 128. We don't use Jasmine Spec Runner, so we can safely use the default.
See: angular/angular-cli#28271 (comment)

},
coverageReporter: {
dir: join(__dirname, './coverage'),
Expand Down
Loading