-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests produce the error "Some of your tests did a full page reload!" after Chrome update #28271
Comments
Same happened here after update Chrome to v128.0.0.0.
|
I noticed that too, but I think once you stop watching it'll spit out the error. |
Also seeing this, and it's not a specific test that fails:
Test output:
|
Similar issue here, does not appear on
|
Related? karma-runner/karma#3560 (comment) I set |
In my case I did the same but still getting the error |
I'm chatting with some Karma folks to see if we can understand what's going on here. Unfortunately we're not able to reproduce the exact issue, so I have a few questions someone can maybe help out with:
|
@dgp1130 Chrome version: 128.0.6613.85
I cannot do this. I just got the error and I am rushing to deliver a product. Maybe if no one else does, I can follow-up later on Tues.
I have ran
I added
I am also on a darwin arm64, so I cannot help there :(
|
I have I'll watch for a minimal example but same as Stargator I get this error on a enterprise product I cannot show the code. |
It caused my pre-push hook to fail and I had to switch off the hooks to be able to push so for us it appears to be actually causing a non-zero exit. |
@dgp1130, I was able to replicate this issue exclusively on macOS, and it occurs in both headless and non-headless modes of Chrome version 128.0.0.0. When |
This works for me. Environment:
|
… for single run executions This works around angular#28271.
… for single run executions This works around angular#28271.
… for single run executions This works around angular#28271.
… for single run executions This works around #28271.
… for single run executions This works around angular#28271. (cherry picked from commit 3ee2163)
… for single run executions This works around angular#28271. (cherry picked from commit 3ee2163)
@alan-agius4 was able to reproduce the issue in a base Karma setup without Angular, so that at least rules out Angular as the root cause here: karma-runner/karma#3887 That said, setting Beyond that, hopefully the Karma and/or Chrome teams can figure out what's going on under the hood here, as there's definitely a deeper root cause which is not understood by us right now. |
Hi @dgp1130, |
Using the The issue only appears for me when running in headless mode with
I don't see the error. |
Configuring karma custom launcher arguments to "--headless=old" fixed it. |
Sharing my experience for others who may still have the same issue. On my side, I am using Chrome 130.0.0.0 with MacOS 10.15.7 darwin arm64, angular cli 16.12.15 and karma 6.4.4. I believe it is a karma issue but they have deprecated the project so not much maintenance to be expected on their end, so posting here in case this is helpful.
|
This PR includes a few efforts to improve frontend CI on macOS. 1. Changed macOS CI to run on arm64 arch instead of x64. The is the main cause of disconnecting issue. 2. Upgraded testing-related packages to the latest: - karma to 6.4.4 (applied a custom fix for Chrome > 128.0.0.0.0 on macOS arm64, see my post angular/angular-cli#28271 (comment)) - jasmine-core to 5.4.0 3. Fixed many problematic test cases, including: - Empty test cases (no `it` cases). - Wrong dependency injection (especially on HttpClient should use `HttpClientTestingModule`). - Wrong global NzMessageModule import.
Which @angular/* package(s) are the source of the bug?
core
Is this a regression?
No
Description
I don't believe is an Angular issue, but I'm creating this report for clarity and to increase visibility.
Since updating to Chrome ~
128.x
running unit tests produce an error in spite of all tests passing. To reproduce you can simply create a new project and runng test
.Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
Please provide the environment you discovered this bug in (run
ng version
)Anything else?
I tested it out on new Angular 17 and 18 projects using node 18 and 20 and get the same results for all of them. I was able to verify that upon reverting to Chrome
127.x
the error is not produced.The text was updated successfully, but these errors were encountered: