Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict NRTs #26

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Enable strict NRTs #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
<PropertyGroup>
<CurrentPreviewTfm>net8.0</CurrentPreviewTfm>
<!--<IncludePreview>true</IncludePreview>-->
<IncludePreview Condition=" '$(IncludePreview)' == ''">false</IncludePreview>
<IncludePreview Condition="'$(IncludePreview)' == ''">false</IncludePreview>
<LangVersion>latest</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<WarningsAsErrors>nullable</WarningsAsErrors>
</PropertyGroup>

<PropertyGroup>
Expand All @@ -19,7 +20,7 @@

<ItemGroup>
<!--
The .NET Framework target doesn't seem to like this implicit using so we
The .NET Framework target doesn't seem to like this implicit using so we
have to bring it in for each file, so might as well remove it for .NET targets too.
-->
<Using Remove="System.Net.Http" />
Expand Down
1 change: 1 addition & 0 deletions src/Sdk/Models/AddAliasRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ private AddAliasRequest(string userId, bool hashing = true)
{
UserId = userId ?? throw new ArgumentNullException(nameof(userId));
Hashing = hashing;
Aliases = new HashSet<string>();
}

public string UserId { get; }
Expand Down