Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict NRTs #26

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Enable strict NRTs #26

merged 1 commit into from
Sep 20, 2023

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Sep 19, 2023

Preventing NRTs is particularly crucial in library code

@Tyrrrz Tyrrrz added the enhancement New feature or request label Sep 19, 2023
justindbaur
justindbaur approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, I'd love to get to a point where we just have all warnings as errors. We need to first actually generate and pack the documentation file and then add docs to everything and then I'd love to turn that on too.

@Tyrrrz Tyrrrz merged commit 4d33713 into main Sep 20, 2023
3 checks passed
@Tyrrrz Tyrrrz deleted the no-nulls branch September 20, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justindbaur justindbaur justindbaur approved these changes

@abergs abergs Awaiting requested review from abergs

@jonashendrickx jonashendrickx Awaiting requested review from jonashendrickx

@jrmccannon jrmccannon Awaiting requested review from jrmccannon

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyrrrz @justindbaur