This repository has been archived by the owner on Jul 23, 2022. It is now read-only.
Patch electron-builder to support universal binaries on Mac #803
+240
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscharf
approved these changes
Mar 22, 2021
|
@Hinton , please add a card to Asana for tech-debt cleanup of this item once upstream issues are resolved/merged in and we can update electron-builder accordingly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When building the Mac App Store package we produce a universal binary (#793.). Unfortunately we get an error when we attempt to include our Safari extension, since it has already been compiled as a universal-binary. Compiling two separate binaries for the extension likewise produces another error. There is an open issue in electron-builder, electron-userland/electron-builder#5552.
However in the meantime this PR will patch electron-builder using patch-package to handle our use case.