Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

Add --universal to mac builds for arm support #793

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

nitrocode
Copy link
Contributor

Closes #792

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2021

CLA assistant check
All committers have signed the CLA.

@cscharf cscharf requested review from Hinton and joseph-flinn March 17, 2021 20:43
package.json Outdated Show resolved Hide resolved
@nitrocode nitrocode requested a review from Hinton March 17, 2021 22:07
package.json Outdated Show resolved Hide resolved
Hinton
Hinton previously approved these changes Mar 18, 2021
@Hinton
Copy link
Member

Hinton commented Mar 18, 2021

Looks good, thanks for the contribution @nitrocode.

package.json Outdated Show resolved Hide resolved
Co-authored-by: Chad Scharf <3904944+cscharf@users.noreply.github.com>
@nitrocode
Copy link
Contributor Author

@Hinton I kept the target consistent using @cscharf suggestion. Thank you!

Copy link
Contributor

@cscharf cscharf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cscharf cscharf merged commit 7b9156c into bitwarden:master Mar 18, 2021
@nitrocode nitrocode deleted the mac-m1-arm branch March 18, 2021 18:20
@nitrocode nitrocode changed the title Add --universal to mac builds Add --universal to mac builds for arm support Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

m1 osx / darwin universal or arm specific binary
4 participants