-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testnet consensus release #1609
Conversation
Note: this should not break compatibility in production because the result should be the same after hard fork #343.
- initial implementation - unit tests: added asset_rewards_test, modified create_advanced_uia
- fix PR notes
- added market_sharing_whitelist option - added tests for asset extensions before and after the hardfork 1268
…ith instant_vesting_policy_initializer
- added check asset restrictions while pay reward - added unit test
fix failing tests in testnet
Prevent oversized transactions
HTLC test failing intermittently
change hardfork dates for the testnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiled on Ubuntu 18.04 / OpenSSL 1.1.0 / Boost 1.67 chain_test ran with no errors detected.
Can we include a snapshot comparison into our standard release procedure? |
I created the snapshots between When comparing i found 3 objects types that changed their structure by the code we are about to merge, i think they are all ok and explainable by our pull request :
Also updated this document: https://github.com/oxarbitrage/documentation/blob/master/snapshot.md Plan to link it in the release steps of the git flow(https://github.com/bitshares/bitshares-core/wiki/Git-Flow) |
We should bump DB_VERSION. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump database in hardfork
changed bump db to hardfork branch here #1616 |
TESTNET - change hf dates to Thursday, February 28, 2019 2:02:00 PM
bringing bump db from hardfork at #1617 |
bring bump db from hardfork to testnet release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiled on Ubuntu 18.10 / Boost 1.67 / OpenSSL 1.1.0. chain_test completed with no errors found.
Merges the
testnet_release
intotestnet
with hardfork activation dates Thursday, February 28, 2019 2:02:00 PMAll testnet block producers must upgrade, API nodes are recommended to upgrade too.