Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define DB_VERSION format #1618

Closed
17 tasks
abitmore opened this issue Feb 25, 2019 · 5 comments
Closed
17 tasks

Define DB_VERSION format #1618

abitmore opened this issue Feb 25, 2019 · 5 comments

Comments

@abitmore
Copy link
Member

User Story
As a developer, usually we need to update DB_VERSION to force a replay when updated database schema (e.g. 9af57a8, dd532f7). When developing different features in multiple branches, usually there will be conflicts on db_version. However, when these is a conflict, the best approach is NOT to accept changes in either branch, instead, it's best to update db_version to a new one. Putting a number or a date in db_version is not intuitive enough to avoid merging issues, see #1609 (review).

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Additional Context (optional)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added the 2a Discussion Needed Prompt for team to discuss at next stand up. label Feb 25, 2019
@ryanRfox
Copy link
Contributor

I suggest to have the DB_VERSION match the outcome of #1173 for Release Version Numbering.

@abitmore
Copy link
Member Author

We don't force replay on every new release, so it's unnecessary to update DB_VERSION every time.

@pmconrad
Copy link
Contributor

DB_VERSION currently has no semantic other than "it changed" or "it didn't". A simple date stamp should be sufficient. Rule for merge conflict: bump to current date.

@oxarbitrage
Copy link
Member

I agree here that just a date will make it and it is more intuitive than a number for conflicts.

YYYYMMDD can be used and i am tempted to say for the releases the format should have full year as well, for example current release tag 2.0.190219 is confusing, 2.0.20190219 is better but that is maybe more a comment to #1173 .

I suggest to leave this issue open as a reminder until we need to bump the database again at any branch, use the timestamp format then and close the issue.

@ryanRfox
Copy link
Contributor

Rule for DB_VERSION format: YYYYMMDD
Rule for merge conflict: bump to current date (YYYYMMDD)

Closing

@abitmore abitmore added informative dev workflow and removed 2a Discussion Needed Prompt for team to discuss at next stand up. labels Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants