-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define DB_VERSION format #1618
Comments
I suggest to have the DB_VERSION match the outcome of #1173 for Release Version Numbering. |
We don't force replay on every new release, so it's unnecessary to update DB_VERSION every time. |
DB_VERSION currently has no semantic other than "it changed" or "it didn't". A simple date stamp should be sufficient. Rule for merge conflict: bump to current date. |
I agree here that just a date will make it and it is more intuitive than a number for conflicts.
I suggest to leave this issue open as a reminder until we need to bump the database again at any branch, use the timestamp format then and close the issue. |
Rule for DB_VERSION format: YYYYMMDD Closing |
User Story
As a developer, usually we need to update DB_VERSION to force a replay when updated database schema (e.g. 9af57a8, dd532f7). When developing different features in multiple branches, usually there will be conflicts on db_version. However, when these is a conflict, the best approach is NOT to accept changes in either branch, instead, it's best to update db_version to a new one. Putting a number or a date in db_version is not intuitive enough to avoid merging issues, see #1609 (review).
Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.
Additional Context (optional)
CORE TEAM TASK LIST
The text was updated successfully, but these errors were encountered: