Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse #1213 #1438

Merged
merged 3 commits into from
Nov 18, 2018
Merged

Reverse #1213 #1438

merged 3 commits into from
Nov 18, 2018

Conversation

oxarbitrage
Copy link
Member

#1213

We found that the UI use the removed object at the voting page bitshares/bitshares-ui#2174

This pull reverses the change.

pmconrad
pmconrad approved these changes Nov 18, 2018
View reviewed changes
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I'd suggest a few style changes, but since the point of this is to revert the previous change I think we should skip the style for now.

@oxarbitrage
Copy link
Member Author

Thanks @pmconrad , i want to get back into this issue too as for example the reverse at tests/tests/bitasset_tests.cpp and tests/tests/operation_tests2.cpp are not needed.
If we really need to keep the object we can do it a bit better, agree.

@oxarbitrage oxarbitrage merged commit 1ba4b28 into bitshares:release Nov 18, 2018
@oxarbitrage oxarbitrage mentioned this pull request Nov 18, 2018
Closed
@abitmore abitmore added this to the Hotfix-201811-1 milestone Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Hotfix-201811-1
Development

Successfully merging this pull request may close these issues.
3 participants
@oxarbitrage @pmconrad @abitmore