-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove not needed budget_record_object creation from maint #1213
Conversation
libraries/chain/db_maint.cpp
Outdated
_rec.record = rec; | ||
}); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this line to a real empty line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO either delete old budget_record_objects to release the space, or remove budget_record_object completely from the code, not only the create<> operation.
Creating + later deleting them would enable plugins to do something with the information (think es_objects). OTOH I think it's unlikely that anyone is using this information, so removing it completely shouldn't hurt.
removed budget_record_object completely as suggested at #1213 (review) cant remove we can maybe change the name of that file to just |
Can move the declaration of struct budget_record into db_maint.cpp, since it's only used internally. |
for issue #1139
chain tests all passing, replayed a few months of the chain without any issue.