Issue1011, Add CLI startup option to only generate keys #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanRfox
added
1c Task
pmconrad
reviewed
Jun 11, 2018
programs/cli_wallet/main.cpp
Outdated
| @@ -86,6 +86,7 @@ int main( int argc, char** argv ) | |||
| ("daemon,d", "Run the wallet in daemon mode" ) | |||
| ("wallet-file,w", bpo::value<string>()->implicit_value("wallet.json"), "wallet to load") | |||
| ("chain-id", bpo::value<string>(), "chain ID to connect to") | |||
| ("suggest-brain-key", "Suggest a safe brain key to use for craeting your account") | |||
There was a problem hiding this comment.
ah oh.. thanks~ fixed
pmconrad
approved these changes
Jun 12, 2018
|
Prior to merge, may I request of @cifer-lee on #1011:
|
ryanRfox
added
the
5a Docs Needed
|
@ryanRfox although having test cases for everything would be a nice thing, it comes with costs. IMHO we can skip test case here, and put efforts elsewhere, for better use. |
abitmore
approved these changes
Jun 15, 2018
|
@ryanRfox I'd like to get this merged, but I don't want to forget about the documentation part. What is the best way to make sure that it gets documented? Merge and close this PR, but keep the issue opened? |
|
@jmjatlanta create a new issue for documentation. |
|
I think we can also move the request for documentation to the issue but not leave it here. |
6 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1011
For code reuse, i moved origin
wallet_api::suggest_brain_key's code intographene::wallet::utilityto make it static method.self test ok.