Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "create-genesis-json" startup option from witness_node #1536

Closed
2 of 19 tasks
abitmore opened this issue Jan 21, 2019 · 11 comments
Closed
2 of 19 tasks

Remove "create-genesis-json" startup option from witness_node #1536

abitmore opened this issue Jan 21, 2019 · 11 comments

Comments

@abitmore
Copy link
Member

User Story
@pmconrad mentioned in #1529 (comment):

... the --create-example-genesis option does not serve a useful purpose.
Things could be simplified by creating an example genesis file somewhere in the documentation, removing that option from the code...

Lately @jmjatlanta implemented the code in commit 46e248e, so the option will be removed if #1529 is merged. Then we need to update related documents and tutorials.

This issue is for tracking documentation work and potential related discussions.

  • find out the documents that need to be updated
  • update the documents

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Additional Context (optional)
Add any other context about your request here.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@jmjatlanta
Copy link
Contributor

I modified the wiki page for private testnet here: https://github.com/bitshares/bitshares-core/wiki/private-testnet

@abitmore
Copy link
Member Author

@cedar-book I guess you're aware of where other related docs are? Please take a look. Thanks.

@abitmore
Copy link
Member Author

abitmore commented Jan 22, 2019

@jmjatlanta please be aware that the private keys for the genesis.json file in testnet branch are not publicly known. For new private testnets, people need to put keys controlled by themselves into genesis.json (like the "create-genesis-file" option did). Current instruction in wiki is not clear enough for newcomers.

A publicly known key pair is:

  • public key: BTS6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV
  • private key: 5KQwrPbwdL6PhXujxW37FSSQZ1JiwsST4cqQzDeyXtP79zkvFD3

Other publicly known private keys can be found in https://github.com/bitshares/bitshares-core/blob/6e11c31d40a8e63f52402887860349d9f96d883b/testnet-shared-private-keys.txt which I guess are paired with the public keys in the end of https://github.com/bitshares/bitshares-core/blob/6e11c31d40a8e63f52402887860349d9f96d883b/testnet-shared-accounts.txt. These files among some other old files have been removed in PR #1533.

By the way, people can use the suggest-brain-key option in cli_wallet to generate new keys pairs. It's introduced in version 2.0.180823 by PR #1039. There may be docs for this, I guess we can link the docs together.

@cedar-book
Copy link

cedar-book commented Jan 22, 2019

@abitmore, yes, I am planing to renew the testnets section (the dev website).

@oxarbitrage
Copy link
Member

Outside the wallet private keys can also be generated with ./get_dev_key --help using the corresponding network prefix("BTS", "TEST", "MY", etc). The public key generated need to go into the private testnet genesis file for active and owner keys of all the "initX" accounts and also to "nathan" Then the public/private key pair is added into the blockchain config.

@cedar-book
Copy link

@oxarbitrage, Thank you for the information! I'll add that how to information.

@reactivespace
Copy link

@jmjatlanta I am setup my dex using Bitshares Core but facing an error while running on lnix. when I run with new chain with zero block process not initiate.

@jmjatlanta
Copy link
Contributor

@reactivespace If you believe that the removal of create-genesis-json is the problem, please post more details of the message you are receiving. For technical assistance, you may try https://bitsharestalk.org.

@cedar-book
Copy link

Updated to remove 'create-genesis-json' command line section - Private Testnet.
To share the Private Testnet Genesis file information, created new page for.

@cedar-book
Copy link

Updated: private testnet - Genesis file section

  • added notes to mention about the above two discussions.

@pmconrad
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants