Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved surface rotation #2543

Merged
merged 7 commits into from
Aug 13, 2023
Merged

feat: improved surface rotation #2543

merged 7 commits into from
Aug 13, 2023

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Aug 7, 2023

Related: #409

Instead of rotating purely the bitmaps inside of each key, this makes it possible to rotate everything about the panel.
For example, a 15 key streamdeck normally occupied a 5x3 area in the grid and once rotated will now occupy a 3x5 area instead.
PXL_20230807_201806284

For backwards compatibility, the old rotation modes have not been removed, that can be done in a later release.

Additionally, xkeys has been reworked, so that it no longer needs to span multiple pages or do other mangling to fit the panels into the grid.
PXL_20230807_194059424
This is controlled by a setting, so that existing xkeys users can choose when to switch their configurations to the new layout.
I have only tested this with a XK-24 and a XK-12 (Jog&Shuttle)
With this new layout, rotation works as you would expect. It is also offered when using the old layout, but makes configuring even more confusing.

loupedeck ct now also uses a single page, with a suitable grid size

@Julusian Julusian marked this pull request as ready for review August 7, 2023 20:14
@Julusian
Copy link
Member Author

Julusian commented Aug 7, 2023

@dnmeid could you verify I haven't broken the loupedeck ct implementation (again)?
It should now reside in a single page. I havent bothered with backwards compatibility, it doesnt feel worth implementing
Its not directly related to this PR, but makes sense to do at the same time.

@Julusian Julusian linked an issue Aug 8, 2023 that may be closed by this pull request
@dnmeid
Copy link
Member

dnmeid commented Aug 10, 2023

I can check CT stuff at the weekend.

@Julusian Julusian added this to the v3.2 milestone Aug 10, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Julusian
❌ dnmeid
You have signed the CLA already but the status is still pending? Let us recheck it.

@dnmeid
Copy link
Member

dnmeid commented Aug 13, 2023

Done a few fixes, Loupedeck CT is happy now.

@Julusian
Copy link
Member Author

Thanks @dnmeid!

@Julusian Julusian merged commit 213ba88 into develop Aug 13, 2023
10 checks passed
@Julusian Julusian deleted the feat/revamped-rotation branch August 19, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature Request: Button layout rotation on programming page
3 participants