Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 20 #738

Closed
chimp1984 opened this issue Dec 26, 2020 · 7 comments
Closed

For Cycle 20 #738

chimp1984 opened this issue Dec 26, 2020 · 7 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:failed Indicates that DAO vote failed to complete.
Milestone

Comments

@chimp1984
Copy link

chimp1984 commented Dec 26, 2020

Summary

  • BSQ requested: 14357.14
  • USD requested: 10050
  • BSQ rate: 0.70 USD per BSQ

Contributions delivered

Title Team USD Link Notes
UI improvements dev 300 bisq-network/bisq#4914 -
Property fields must not be set from non JavaFX threads dev 50 bisq-network/bisq#4916 -
Detect and handle invalid maker fee tx dev 300 bisq-network/bisq#4917 -
Revert TTL to original value of 15 days dev 0 bisq-network/bisq#4920 -
Detect missing deposit tx to allow moving to failed trades dev 200 bisq-network/bisq#4921 -
Fix sorting of table columns dev 100 bisq-network/bisq#4923 -
Improve shutdown routine dev 100 bisq-network/bisq#4927 -
Make sign age column sortable dev 300 bisq-network/bisq#4929 -
Use HistoricalDataStoreService for AccountAgeWitnessStorageService dev 300 bisq-network/bisq#4930 -
Improve funds and portfolio screens dev 400 bisq-network/bisq#4933 -
Add wallet info view dev 500 bisq-network/bisq#4935 -
Refactor http client dev 300 bisq-network/bisq#4942 -
Add tx broadcast to mempool explorer api dev 1300 bisq-network/bisq#4943 -
Improve TransferWise account dev 100 bisq-network/bisq#4944 -
Fix bug with maker fee tx at create offer dev 100 bisq-network/bisq#4947 -
Show price deviation in % for fixed price offers and BSQ dev 900 bisq-network/bisq#4949 -
Allow sending private notifications from avatar icon at trade dev 100 bisq-network/bisq#4952 -
Cache results in account witness domain dev 600 bisq-network/bisq#4953 Includes Profiling work
Various small improvements dev 100 bisq-network/bisq#4954 -
Cache results of isFiatCurrency and isCryptoCurrency dev 400 bisq-network/bisq#4955 Profiling was main effort here
Sort payment methods by display string not by id dev 50 bisq-network/bisq#4956 -
Do not use tx broadcast to mempool nodes if a local btc nodes is used dev 100 bisq-network/bisq#4958 -
Call completeHandler if services in store services is empty dev 200 bisq-network/bisq#4963 -
Avoid resync from genesis in case of dao state issues dev 300 bisq-network/bisq#4971 -
Improve logs dev 100 bisq-network/bisq#4973 -
Fix nullpointer dev 0 bisq-network/bisq#4974 -
Improve CleanupMailboxMessages dev 400 bisq-network/bisq#4975 -
Remove NGN (Nigerian Naira) as their central bank blocked Transferwise dev 50 bisq-network/bisq#4976 -
Add extra note for amazon gift cards dev 100 bisq-network/bisq#4977 -
Fix wrong account age data access dev 200 bisq-network/bisq#4981 Includes debugging efforts
Improve popup text in case a local node is detected dev 50 bisq-network/bisq#4984 -
Improve trade fee display at create and take offer screens and popups dev 400 bisq-network/bisq#4985 -
Remove redundant popup dev 50 bisq-network/bisq#4987 -
Add mediators keybase usernames dev 100 bisq-network/bisq#5004 -
Release testing dev 500 - -
Technical user support support 1000 - -

Note:

I added contributions from the start of cycle 20 only (9.12.2020). I did not request compensation of my work of the past months, but might add that to future requests.

Contributions in progress

Title Team USD Link Notes
Improve offer publishing dev 300 bisq-network/bisq#4950 -
Move BSQ price in USD at first row dev 50 bisq-network/bisq#4988 -
Add percentage price to open offer view dev 200 bisq-network/bisq#4993 -
Cleanup trade wallet code dev 50 bisq-network/bisq#4997 -
Add generic map (cookie) to UserPayload dev 300 bisq-network/bisq#4999 -
Deactivate open offer if trigger price is reached dev 2300 bisq-network/bisq#5001 -
Add estimated size to log of initial data response dev 50 bisq-network/bisq#5009 -
Dao performance improvements dev 50 bisq-network/bisq#5010 -
Show stacktrace in error popup at view exceptions dev 50 bisq-network/bisq#5011 -
Change trade period for transferwise from 1 day to 4 days dev 150 bisq-network/bisq#5016 Effort was testing backward compitability
Improve getBlocks request handling dev 400 bisq-network/bisq#4851 -
@ghost
Copy link

ghost commented Dec 26, 2020

Info

Read BSQ amount from summary: 14957
Read USD amount from summary: 9950
Read BSQ rate from summary: 0.7
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":200}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":400}
Parsed lineitem: {"team":"dev","amount":500}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":1300}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":900}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":600}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":400}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":200}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":400}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":200}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":400}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":500}
Parsed lineitem: {"team":"support","amount":1000}

Errors

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 14957.00 BSQ
  • Calculated total: 14214.29 BSQ

@ghost ghost added parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team labels Dec 26, 2020
@ghost
Copy link

ghost commented Dec 26, 2020

Info

Read BSQ amount from summary: 1421429
Read USD amount from summary: 9950
Read BSQ rate from summary: 0.7
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":200}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":400}
Parsed lineitem: {"team":"dev","amount":500}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":1300}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":900}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":600}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":400}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":200}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":400}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":200}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":400}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":500}
Parsed lineitem: {"team":"support","amount":1000}

Errors

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 1421429.00 BSQ
  • Calculated total: 14214.29 BSQ

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Dec 26, 2020
@chimp1984 chimp1984 changed the title For Cycle 20 [WIP] For Cycle 20 Dec 26, 2020
@chimp1984 chimp1984 changed the title [WIP] For Cycle 20 For Cycle 20 Dec 28, 2020
@ripcurlx
Copy link
Contributor

As team lead I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@MwithM MwithM assigned ripcurlx and unassigned ripcurlx Dec 28, 2020
@MwithM MwithM added this to the Cycle 20 milestone Dec 28, 2020
@leo816
Copy link

leo816 commented Dec 29, 2020

My Team Lead review is complete and I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@chimp1984
Copy link
Author

Tx ID: 05bfc43fd904c15f3ffe92dd40b7768c0154146782bcb3cb2060902e01a84ecc

@freimair
Copy link
Member

freimair commented Jan 1, 2021

Following Bisq's policy and budgeting efforts render PR (or issues fixed) not marked "bug", "critical" or "priority" to not be up for compensation in order to battle overspending, BSQ inflation, and focus work on what is most important. This has been put in place months ago and enforced ever since.

Looking at your CR while keeping the aforementioned Bisq policy and budgeting efforts in mind, makes the mind boggle. A number of items, in fact, none of them, are marked "bug", "critical" or "priority". Wouldn't that indicate that the amount your are asking for is somewhat off?

@MwithM MwithM added the was:failed Indicates that DAO vote failed to complete. label Jan 10, 2021
@MwithM
Copy link
Contributor

MwithM commented Jan 10, 2021

Cycle 20 DAO vote failed. Submit a new DAO request for next cycle.

@MwithM MwithM closed this as completed Jan 10, 2021
@freimair freimair mentioned this issue Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:failed Indicates that DAO vote failed to complete.
Projects
Archived in project
Development

No branches or pull requests

5 participants