Avoid resync from genesis in case of dao state issues #4971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now all dao store files and request a shut down of the app. After a restart the resource files are used. This avoids cases where a resync from genesis got triggered (observed on seed nodes, not on desktop apps). Seed nodes and headless apps get shut down automatically. In case of the desktop app we show a warn popup with shutdown button and no close button, so we enforce a shutdown to avoid complications in case the user would continue.
|
A test is broken. Please see Travis log. |
sqrrm
approved these changes
Dec 21, 2020
There was a problem hiding this comment.
utACK
@chimp1984 You need to get the ack from @ManfredKarrer as well
chimp1984
deleted the
use-resource-file-instead-of-resync-from-genesis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a reset of the dao state was triggered we delete now all dao store files and request a shut down of the app.
After a restart the resource files are used. This avoids cases where a resync from
genesis got triggered (observed on seed nodes, not on desktop apps).
Seed nodes and headless apps get shut down automatically.
In case of the desktop app we show a warn popup with shutdown
button and no close button, so we enforce a shutdown to avoid
complications in case the user would continue.