Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve popup text in case a local node is detected #4984

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Improve popup text in case a local node is detected #4984

merged 2 commits into from
Dec 22, 2020

Conversation

chimp1984
Copy link
Contributor

Improve popup text in case a local node is detected

@chimp1984
Copy link
Contributor Author

@m52go Could you review?

popup.bitcoinLocalhostNode.msg=Bisq detected a locally running Bitcoin Core node (at localhost).\n\\n\
  Please ensure that following requirements are met when using a local Bitcoin Core node:\n\
  - The node need to be fully synced before you start Bisq\n\
  - The node need to have pruning disabled (option: 'prune=0')\n\
  - The node need to have bloom filters enabled (option: 'peerbloomfilters=1')

@chimp1984
Copy link
Contributor Author

chimp1984 commented Dec 20, 2020 •
edited
Loading

Before:
Screen Shot 2020-12-20 at 13 23 29

After:
Screen Shot 2020-12-20 at 13 27 57

@chimp1984 chimp1984 force-pushed the improve-localnode-popup-text branch 2 times, most recently from 2ca6f26 to b26c826 Compare December 20, 2020 18:27
@ripcurlx ripcurlx added this to the v1.5.3 milestone Dec 21, 2020
@m52go
Copy link
Contributor

m52go commented Dec 21, 2020

Suggestion:

popup.bitcoinLocalhostNode.msg=Bisq detected a Bitcoin Core node running on this machine (at localhost).\n\n\
  Please ensure:\n\
  - the node is fully synced before starting Bisq\n\
  - pruning is disabled ('prune=0' in bitcoin.conf)\n\
  - bloom filters are enabled ('peerbloomfilters=1' in bitcoin.conf)

@chimp1984
Copy link
Contributor Author

Thanks @m52go ! Much better!

ripcurlx
ripcurlx approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 73fdb9f into bisq-network:master Dec 22, 2020
@chimp1984 chimp1984 deleted the improve-localnode-popup-text branch December 22, 2020 14:07
@chimp1984 chimp1984 mentioned this pull request Dec 26, 2020
Closed
@chimp1984 chimp1984 mentioned this pull request Jan 27, 2021
Closed
@chimp1984 chimp1984 mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.5
Development

Successfully merging this pull request may close these issues.
3 participants
@chimp1984 @m52go @ripcurlx