User defined trade limit, Part II. #6433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some commits were missed from the first implementation in #6431. The user limit is applied to offer entry via AccountAgeWitnessService. Offers are filtered according to limits in OfferFilterService. If limit changed, the cache in OfferFilterServices must be cleared.
|
When the user defined trade limit is activated this pops up when a user tries to take an offer that he's not allowed to take. Do we want to add "user defined trade limit" to the list or is it hidden on purpose so that only experienced traders know about this feature?
|
ghost
dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #6431, some commits were misplaced during a code rebase.