Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase trading limits as an opt-in setting #6431

Merged
merged 1 commit into from Nov 29, 2022
Merged

Increase trading limits as an opt-in setting #6431

merged 1 commit into from Nov 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 27, 2022

Implements proposal 398 and proposal 395

  • User's initial max limit is 0.1 BTC, can be self-increased upto the max trade limit DAO param.
  • More restrictive limits will still apply based on payment method.
  • XMR Auto-Confirm will default to enabled for new users.

It is intended to avoid that a new users who do not fully understand the process of a Bisq trade to cause an arbitration case with high amounts and therefore higher risks and costs for the DAO.


image

image

image

image

image

image

HenrikJannsen
HenrikJannsen previously approved these changes Nov 27, 2022
Copy link
Collaborator

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghost ghost closed this Nov 29, 2022
@ghost ghost reopened this Nov 29, 2022
@ghost
Copy link
Author

ghost commented Nov 29, 2022

Rebased, resolved conflicts and applied @MwithM's review suggestions.

More restrictive limits will still apply based on payment method.

It is intended to avoid that a new users who do not fully understand
the process of a Bisq trade to cause an arbitration case with high
amounts and therefore higher risks and costs for the DAO.
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 061863a into bisq-network:master Nov 29, 2022
@ghost ghost mentioned this pull request Nov 30, 2022
@ripcurlx ripcurlx added this to the v1.9.7 milestone Dec 1, 2022
@ghost ghost mentioned this pull request Dec 7, 2022
@ripcurlx
Copy link
Contributor

I just tested this feature and I'm not sure if it might be confusing for existing users. E.g. someone who has already signed accounts and traded e.g. 0.25 BTC on SEPA or 2 BTC on XMR will see this new limit applied when creating an offer.

Bildschirmfoto 2022-12-19 um 09 54 01
Bildschirmfoto 2022-12-19 um 09 53 51

Now they have no idea how to change this user set trade limit except trying to reach out in forums, searching through the app settings. I think we should add an informational popup on startup and a NEW badge on the Settings menu item.

@jmacxx @HenrikJannsen @pazza83, @MwithM: WDYT?

@ripcurlx
Copy link
Contributor

Bildschirmfoto 2022-12-19 um 10 01 38

I also think this popup needs to be adapted pointing out this new user limit feature, wdyt?

@ghost
Copy link
Author

ghost commented Dec 19, 2022

@ripcurlx For an existing user we could initialize the limit to the size of their largest prior trade. #6473

@ripcurlx
Copy link
Contributor

@ripcurlx For an existing user we could initialize the limit to the size of their largest prior trade. #6473

Yes, maybe that would be even better, so existing users wouldn't recognize anything at all. 👍

@MwithM
Copy link
Contributor

MwithM commented Dec 20, 2022

@ripcurlx I agree that this pop-ups (and the wiki), needs to be updated, but the assumption is that if a user doesn't know how to increase the limits, they won't know other basic stuff that generates trade going to mediation, like where to ask for support.

On that pop-up I would only add the bold text:

To limit chargebacks on fiat payment methods, Bisq sets per-trade limits...

Then, the account limits wiki article nedds to be edited to point exactly how to increase limits for alts. That way, is more probable that users who raised the limit at least know about the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants