Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix republish trade stats #4662

Merged
merged 4 commits into from
Oct 16, 2020
Merged

Fix republish trade stats #4662

merged 4 commits into from
Oct 16, 2020

Commits on Oct 16, 2020

  1. Handle Capabilities for encrypted messages (offer availibility reques… 

    …t/response)

We did check in Connection for SupportedCapabilitiesMessage and if a message is of that type we set the capability.
But encrypted messages are wrapped in a PrefixedSealedAndSignedMessage so the payload is not visible as SupportedCapabilitiesMessage without decrypting it.
We need to call maybeHandleSupportedCapabilitiesMessage at decrypting the message. We do that only for direct messages not for mailbox messages as we likely do not have a connection open to the peer in that case (otherwise it would not be a mailbox msg) and as we don't have the connection available (we get is as AddDataMessage broadcast from an peer, so could could not apply it to the Connection of the sender.
    @chimp1984
    chimp1984 committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    6b4d77f View commit details
    Browse the repository at this point in the history

  2. Add file name to temp file at write to disk

    @chimp1984
    chimp1984 committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    0b38fcc View commit details
    Browse the repository at this point in the history

  3. Fix min height for trade statistics table

    @chimp1984
    chimp1984 committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    8cb6a05 View commit details
    Browse the repository at this point in the history

  4. Republish trade statistics if not found in existing trade stats. 

    Remove republishing at SellerProtocol as we don't know the capability of the peer at that moment and as we also want to republish for completed trades.
    @chimp1984
    chimp1984 committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    294b45d View commit details
    Browse the repository at this point in the history