Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix republish trade stats #4662

Merged

Conversation

chimp1984
Copy link
Contributor

At init trades we iterate all trades (closed and pending) and check if the trade statistics contain a trade stat from that trade. First we check for the new TradeStatistics3, if not found we lookup for the hash of TradeStatistics2 created from that trade. If also not found and if it is valid data we republish the TradeStatistics3.

Remove republishing at SellerProtocol as we don't know the capability of the peer at that moment and as we also want to republish for completed trades.

…t/response)

We did check in Connection for SupportedCapabilitiesMessage and if a message is of that type we set the capability.
But encrypted messages are wrapped in a PrefixedSealedAndSignedMessage so the payload is not visible as SupportedCapabilitiesMessage without decrypting it.
We need to call maybeHandleSupportedCapabilitiesMessage at decrypting the message. We do that only for direct messages not for mailbox messages as we likely do not have a connection open to the peer in that case (otherwise it would not be a mailbox msg) and as we don't have the connection available (we get is as AddDataMessage broadcast from an peer, so could could not apply it to the Connection of the sender.
Remove republishing at SellerProtocol as we don't know the capability of the peer at that moment and as we also want to republish for completed trades.
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit 0dea954 into bisq-network:release/v1.4.0 Oct 16, 2020
@chimp1984 chimp1984 deleted the fix-republish-trade-stats branch October 17, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants