Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix temp file path memory leak #3817

Merged
merged 2 commits into from
Jan 2, 2020
Merged

Fix temp file path memory leak #3817

merged 2 commits into from
Jan 2, 2020

Commits on Dec 20, 2019

  1. Remove redundant locking from FileManager.saveToFile 

    As this private method is synchronized and not used in a way that
recursion/reentry is possible, any further instance-level locking within
the method is redundant - for each FileManager instance, there can only
be one saveToFile call in progress at a time.
    @stejbac
    stejbac committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    aa9146f View commit details
    Browse the repository at this point in the history

  2. Reuse temp file names to fix a memory leak caused by deleteOnExit() 

    The internal 'java.io.DeleteOnExitHook' uses a LinkedHashSet of paths to
to delete files at when the JVM exits. However, since there is no way to
remove entries from the set, it leaks memory when calling deleteOnExit()
for every new temp file created by FileManager.saveToFile. To avoid
this, try to reuse file names (using one per FileManager instance).

(FileManager.saveToFile appears to be called on average around every 2s,
and this probably leaks around 36 + length * 2 bytes for the String
object, 36 bytes for the hashtable node and maybe around 10 bytes for
the table entry, or 82 + length * 2 ~= 236 bytes for a typical temp file
path length on Windows - about 10MB per day.)
    @stejbac
    stejbac committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    80ac646 View commit details
    Browse the repository at this point in the history