Fix temp file path memory leak #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this private method is synchronized and not used in a way that recursion/reentry is possible, any further instance-level locking within the method is redundant - for each FileManager instance, there can only be one saveToFile call in progress at a time.
The internal 'java.io.DeleteOnExitHook' uses a LinkedHashSet of paths to to delete files at when the JVM exits. However, since there is no way to remove entries from the set, it leaks memory when calling deleteOnExit() for every new temp file created by FileManager.saveToFile. To avoid this, try to reuse file names (using one per FileManager instance). (FileManager.saveToFile appears to be called on average around every 2s, and this probably leaks around 36 + length * 2 bytes for the String object, 36 bytes for the hashtable node and maybe around 10 bytes for the table entry, or 82 + length * 2 ~= 236 bytes for a typical temp file path length on Windows - about 10MB per day.)
|
Great finding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal
java.io.DeleteOnExitHookuses aLinkedHashSetof paths to delete files at when the JVM exits. However, since there is no way to remove entries from the set, it leaks memory when callingdeleteOnExit()for every new temp file created byFileManager.saveToFile. To avoid this, try to reuse temp file names (using one perFileManagerinstance).FileManager.saveToFileappears to be called on average around every 2s, and this probably leaks around 36 + length * 2 bytes for the String object, 36 bytes for the hashtable node and maybe around 10 bytes for the table entry, or 82 + length * 2 ~= 236 bytes for a typical temp file path length on Windows - about 10MB per day.