Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GO rule 20 (obsolete term repair) before GO rule 28 (term aspect check) #576

Open
dustine32 opened this issue Jun 15, 2021 · 2 comments
Assignees

Comments

@dustine32
Copy link
Collaborator

Originating from geneontology/pipeline#242 (comment).

Use case here is converting a GPAD, which lacks aspect column, into GAF. For most annotations the null aspect is correctly filled in from the ontology term property hasOBONamespace. But this property is missing for obsolete terms (like GO:0044212), so the resulting GAF line will have a blank aspect column. To fix:

we want to aim to repair the obsoleted term (via GO rule 20) before attempting to extract the aspect in GO rule 28. This way the correct term (GO:0000976) is in place for aspect extraction.

So far, this reordering of rules just looks to involve moving up a few code lines in gpadparser.py. We may want to also do this in gafparser.py for consistency even though it's likely a non-issue for GAF inputs since the aspects are already explicitly set?

@kltm
Copy link
Member

kltm commented Jun 16, 2021

@dustine32 I guess this was a problem for geneontology/pipeline#242 , right?
Just to keep everybody at the same place, we can bump go-site master to 2.7.6 for ontobio and then have the test branches catch up there.

kltm added a commit to geneontology/go-site that referenced this issue Jun 16, 2021
@sierra-moxon
Copy link
Member

updated ZFIN branch and rerunning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants