Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with outside rules and indent rule #15

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Fix issue with outside rules and indent rule #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bffd9f0
fix: issue with outside rules and indent rule
adrienne-deriv Mar 1, 2024
a96f7d6
chore: upgraded prettier plugin to v5
adrienne-deriv Mar 1, 2024
67a46ab
chore: upgraded prettier plugin to v5
adrienne-deriv Mar 1, 2024
d319598
chore: upgraded prettier plugin to v5
adrienne-deriv Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,15 +202,15 @@ module.exports = {
],
},
],
"linebreak-style": ["error", "unix"],
"jsx-quotes": ["error", "prefer-single"],
"no-confusing-arrow": ["error", { allowParens: false }],
"no-tabs": ["error", { allowIndentationTabs: true }],
indent: ["error", 4],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these rules are based on migrating prettier to eslint: #12, assigned ident rule to have a tab width of 4 based on prettierrc
Screenshot 2024-03-01 at 12 08 47 PM

quotes: [
"error",
"single",
{ avoidEscape: true, allowTemplateLiterals: false },
],
},
"linebreak-style": ["error", "unix"],
"jsx-quotes": ["error", "prefer-single"],
"no-confusing-arrow": ["error", { allowParens: false }],
"no-tabs": ["error", { allowIndentationTabs: true }],
indent: ["error", false],
quotes: [
"error",
"single",
{ avoidEscape: true, allowTemplateLiterals: false },
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prettier rules were outside of the rules attribute:
Screenshot 2024-03-01 at 12 17 58 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

};
81 changes: 59 additions & 22 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"eslint-plugin-jest": "^27.4.2",
"eslint-plugin-jest-dom": "^5.1.0",
"eslint-plugin-jest-playwright": "^0.9.0",
"eslint-plugin-prettier": "^3.3.1",
"eslint-plugin-prettier": "^5.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded eslint-plugin-prettier to v5 to resolve error based on this issue

Screenshot 2024-03-01 at 12 36 36 PM

"eslint-plugin-react": "^7.28.0",
"eslint-plugin-react-hooks": "^4.5.0",
"eslint-plugin-simple-import-sort": "^10.0.0",
Expand All @@ -60,7 +60,7 @@
"eslint-plugin-jest": "^27.4.2",
"eslint-plugin-jest-dom": "^5.1.0",
"eslint-plugin-jest-playwright": "^0.9.0",
"eslint-plugin-prettier": "^3.3.1",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-react": "^7.28.0",
"eslint-plugin-react-hooks": "^4.5.0",
"eslint-plugin-simple-import-sort": "^10.0.0",
Expand Down