Fix issue with outside rules and indent rule #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienne-deriv
commented
Mar 1, 2024
| "jsx-quotes": ["error", "prefer-single"], | ||
| "no-confusing-arrow": ["error", { allowParens: false }], | ||
| "no-tabs": ["error", { allowIndentationTabs: true }], | ||
| indent: ["error", 4], |
There was a problem hiding this comment.
Since these rules are based on migrating prettier to eslint: #12, assigned ident rule to have a tab width of 4 based on prettierrc
adrienne-deriv
commented
Mar 1, 2024
| "error", | ||
| "single", | ||
| { avoidEscape: true, allowTemplateLiterals: false }, | ||
| ], |
There was a problem hiding this comment.
The prettier rules were outside of the rules attribute:
shayan-deriv
approved these changes
Mar 1, 2024
aswathy-deriv
approved these changes
Mar 1, 2024
adrienne-deriv
commented
Mar 1, 2024
| @@ -37,7 +37,7 @@ | |||
| "eslint-plugin-jest": "^27.4.2", | |||
| "eslint-plugin-jest-dom": "^5.1.0", | |||
| "eslint-plugin-jest-playwright": "^0.9.0", | |||
| "eslint-plugin-prettier": "^3.3.1", | |||
| "eslint-plugin-prettier": "^5.0.0", | |||
There was a problem hiding this comment.
Upgraded eslint-plugin-prettier to v5 to resolve error based on this issue
ali-hosseini-deriv
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where some prettier rules are outside the
rulesattribute, andidenthas invalid argumentfalse