sni-qt improvements #243

bilelmoussaoui · 2016-12-09T23:37:44Z

In order to get all the sni-qt issues fixed and help us improve user experience here's a list of things that i will try to sort out if have some free time soon.

In order to debug issues correctly. We must add a log file somewhere and save all important information; icon names, application name and stuff like that. We can save that here ~/.cache/sni-qt/logs
The possibility to use SVG icons too instead of using only png icons which are really ugly.

The text was updated successfully, but these errors were encountered:

andia89 · 2016-12-10T07:06:09Z

Svg is easy; I already know how to do that. We have to change the way sni-qt icons are handled than though, since we have to do everything with symlinks then.

Currently I'm trying to figure out what's wrong with teamviewer, maybe this solves also the owncloud issue (which I cannot reproduce)

andia89 · 2016-12-10T10:18:05Z

It should now be possible to use svg icons instead of png icons. @bil-elmoussaoui Can you try out as well?

bilelmoussaoui · 2016-12-10T10:55:12Z

I have to build sni-qt for Archlinux first, i will report back this evening

bilelmoussaoui · 2016-12-10T12:00:05Z

By the way do you have any idea what's this is file for? /etc/xdg/sni-qt.conf?

andia89 · 2016-12-10T16:51:59Z

No idea.

We have to change the way the script works slightly, in order to make it work with svg files. We can do everything symlink (doesn't matter if they are svg or png), but we have to store them in .local/share/sni-qt/icons/{app}/{size}/.

The modified sni-qt package, then looks for these folders and can determine the correct sizes. The problem is, that there is no easy way to determine original svg sizes in Qt

andia89 · 2016-12-10T20:34:51Z

Yeah with my latest improvements (coding in c++ is really really hard for me). We can now use svg icons as well. But we have to change the script as I said already earlier.

Another problem is, that it is not backwards compatible, not much we can do about that unfortunately. So people will have to use that instead of the "old" patched version. I think we have to put that somewhere in the readme very prominent, just as we did it for numix-folders

bilelmoussaoui · 2016-12-10T20:58:01Z

Can you update the python script too? If you can't I will do that ;) and my C++ is not that bad, I think I will be able to implement a correct logging system

andia89 · 2016-12-10T21:00:27Z

I can. But I'll do that on a separate branch for now until everything is set up correctly.

bilelmoussaoui · 2016-12-10T21:28:47Z

Perfect. What do you think about moving our sni-qt branch from bzr (launchpad) to github? This will attract more attention ;) Le 10 déc. 2016 10:00 PM, "Andreas Angerer" <notifications@github.com> a écrit :

…

I can. But I'll do that on a separate branch for now until everything is set up correctly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#243 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHTlxeRFBStq3kNFQUJWOAisbjT4jENzks5rGxLsgaJpZM4LJd6-> .

andia89 · 2016-12-10T21:30:58Z

I guess that's fine. I don't like bzr anyways, this way we can use git, and just mirror it to github for making the ppa

andia89 · 2016-12-10T21:40:16Z

Pushed changes to cript to new branch sni-qt

bilelmoussaoui · 2016-12-10T21:48:11Z

Looks OK for me, but you have removed the chrome script :P

andia89 · 2016-12-10T21:48:44Z

added it again :)

Let's finish the sni-qt programming before we push this to master...

Can you to the transfer to git? I'll add the import on launchpad then who does all the stuff necessary for the ppa

bilelmoussaoui · 2016-12-11T03:29:07Z

Done https://github.com/bil-elmoussaoui/sni-qt, i created a PPA just for sni-qt as we can't keep both of them on the same repo (as a branch for example...); Once the script grows bigger, we might move from a simple project repository to a much complex one.

Added you also as a collaborator. I couldn't keep the bzr log history of commits and move it to git as bzr fastimport does not support feature commit-properties. And there's some useful information on the README file of the repository by the way.

I will work on creating a proper Arch package, and see if it's possible to do the same for Fedora. Once it's done, we merge the sni-qt branch

andia89 · 2016-12-11T06:29:15Z

I think it would be a good idea to add this to the Same ppa. We can use git Import on launchpaf

andia89 · 2016-12-11T11:30:08Z

I uploaded the new git based sni-qt to the ppa. It seems to work. TeamViewer still doesnt though

bilelmoussaoui · 2016-12-11T14:17:07Z

Just tried the new PPA on xubuntu. I think that the Installation of Hardcode-Tray is not working as it's supposed to. The hardcode-tray file should be installed on /usr/bin instead of /opt/Hardcode-Tray/

andia89 · 2016-12-11T14:18:07Z

But it Generates a symlink, doesnt it?

bilelmoussaoui · 2016-12-11T14:19:29Z

Nop it doesn't as far as i can see. I tried hardcode-tray but i get the following message hardcode-tray: command not found

bilelmoussaoui · 2016-12-11T14:23:22Z

also, we must bump the version number of sni-qt on our PPA as Ubuntu provide a non patched version of sni-qt with the version 0.2.8.0. Maybe using 0.2.8.1 for the beta tests and after that we release a 0.2.9.0; what do you think?
Also, we can enable debugging by default; in order to avoid users modifying files with root permissions

andia89 · 2016-12-11T14:23:52Z

Hmm. It does for me. I included a postinst routine that generates the symlink

andia89 · 2016-12-11T14:24:46Z

the latest version ubuntu provides is 2.7.0 so ours should be newer, actually. I don't get how the debugging works. Where is the log stored?

bilelmoussaoui · 2016-12-11T14:25:36Z

On Ubuntu 16.04 i have 0.2.8 :P

andia89 · 2016-12-11T14:26:12Z

because you were installing from the previous ppa :P, not the official ubuntu sources. It doesn't make a lot of sense to bump the version number to 0.2.8 because if ubuntu releases a new version, this version might be 0.2.8 which means that we should adapt our patches

andia89 · 2016-12-11T14:30:56Z

BTW: I'm not sure it is a good idea that we changed the README just yet, because for now the script is not compatible with the ppa

bilelmoussaoui · 2016-12-11T14:36:50Z

Alright! For the PPA, i will revert that ;) Btw, the svg icons or the patch doesn't seem to work as it should here on XFCE

On this screenshot, the missing icon is used instead of Skype icons;

andia89 · 2016-12-11T14:41:26Z

Hmm. Do the icons exist in /tmp?
And you have installed the sni-qt:i386 version from the ppa?
YOu should have a folder called ~/.local/share/sni-qt/skype/24/...svg do you have that?

bilelmoussaoui · 2016-12-11T14:53:06Z

No icons on /tmp. Only an empty folder, which is normal? the sni-qt:i386 is installed and i do have those icons

andia89 · 2016-12-13T19:47:57Z

For me it works also with 24px icons, you sure you're not doing anything wrong?

bilelmoussaoui · 2016-12-13T19:49:06Z

I have removed XFCE the same day as i fucked up everything on my system.. I will reinstall it later and see if i can reproduce the same issue

bilelmoussaoui · 2016-12-15T01:38:24Z

Okey, i have tried the latest PPA of sni-qt, on elementary OS 0.4. I have installed both skype and megasync; Megasync works fine, but skype does not :(

KottV · 2016-12-15T06:46:27Z

what megasync version you have? version <2.9.9 was Qt4-based, thus worked fine
my latest 2.9.10 uses Qt5, so, icon cannot be overrided (i guess)?

andia89 · 2016-12-15T09:01:13Z

what icons to you have in .local/share/sni-qt/icons? and in /tmp

KottV · 2016-12-15T12:11:44Z

I got some troubles right now: #250
so, there no any icons in .local/share/sni-qt/icons

AFAIK, Qt5-apps works with notification protocol native, without sni-qt (which for Qt4, obviously)

bilelmoussaoui · 2016-12-27T19:42:56Z

@KottV I'm using MegaSync 2.9.10-25
@wa4557 Sorry for the delay, I had svg icons under 24 or 22 folder. I tried to use png icons but nothing changed :( is there a way to log each icon path? so we can see if the icons paths are correct or not. And we have also to enable logging by default and get the log file (we might need to add those information later to the wiki)

KottV · 2016-12-28T03:12:12Z

Excuse me for offtop, is your megasync built against Qt5?

bilelmoussaoui · 2016-12-28T10:18:44Z

The default deb package is built using qt4 but on archlinux the package is built using qt5. And I really don't have any idea how to get that fixed as the icons are saved on tmp..

andia89 · 2017-01-01T20:49:40Z

Ok so the Icons are in the tmp folders?

bilelmoussaoui · 2017-01-01T20:53:39Z

@wa4557 on XFCE the icons are shown in tmp folder. But on on Archlinux, i couldn't find the icons anywhere :( and i don't know if we can modify the binary file (just by looking at the result of hexdump and xxd)

andia89 · 2017-01-01T20:57:04Z

Wait what are We talking about? Which binary File? So it works in xfce but Not on Arch? Are you using the correct code for Arch?

bilelmoussaoui · 2017-01-01T20:58:37Z

I was talking about megasync icons. On elementary, skype icons are not on tmp folder and i was using the correct script and the correct version of sni-qt.

andia89 · 2017-01-01T21:01:47Z

Fine. But this issue ist about sni-qt . I still sonst understand if my Code is now working or Not.

andia89 · 2017-01-01T21:03:23Z

Sni qt only works for qt4. It will NEVER work for qt5

bilelmoussaoui · 2017-01-01T21:03:34Z

I think skype is like using an old version of Qt, which causes those issues. I will try with other qt applications that uses sni-qt and will see what i got ;)

bilelmoussaoui · 2017-01-02T22:29:44Z

@wa4557 Just tried the following application

Flareget : works fine
Bitcoin does not work even if the icon in /tmp is the correct icon (and it keep using the non monochrome icon) i will restart my system and try again
Megasync works fine
OwnCloud does not work as per ownCloud Not Being Fixed #226
Skype neither
Mumble works fine
Museeq works fine too
Edit
Seafile does not work at all, the same issue as owncloud (built using qt5?)

bilelmoussaoui · 2017-01-02T22:31:08Z

andia89 · 2017-01-03T16:28:00Z

owncloud switched to qt5 so it cannot work with sni-qt. skype is strange, since it works for me fine...
Bitcoin seems to be either qt4 or qt5 I don't know which version you are using.

bilelmoussaoui · 2017-01-03T16:49:33Z

@wa4557 bitcoin in my case is using sni-qt (so it uses qt4) but the right icon is not shown...well, i think the best idea to test all of this is to release a beta version using sni-qt; but first we need to test how the debugging works

bilelmoussaoui · 2017-01-10T18:52:11Z

@wa4557 I'm going to merge your fix for sni-qt icons to master and release a new version. And we fix the issues that the users will report ;)

bilelmoussaoui · 2017-01-10T19:49:41Z

On master! i'm going to create an AUR package for the pached version of sni-qt

andia89 · 2017-01-11T21:24:53Z

That's cool! Do you know where the logs are stored?

bilelmoussaoui · 2017-01-11T22:02:50Z

Just run the application using terminal and you will have something like this

"sni-qt/31386" DEBUG 23:01:13.831 StatusNotifierItemFactory::StatusNotifierItemFactory() m_iconCacheDir: "/tmp/sni-qt_flareget_31386-VaEb1c" 
"sni-qt/31386" DEBUG 23:01:13.831 void StatusNotifierItemFactory::connectToSnw() 
"sni-qt/31386" DEBUG 23:01:13.832 void StatusNotifierItemFactory::connectToSnw() m_isAvailable: true 
"sni-qt/31386" DEBUG 23:01:13.833 virtual QAbstractSystemTrayIconSys* StatusNotifierItemFactory::create(QSystemTrayIcon*) 
"sni-qt/31386" DEBUG 23:01:13.833 StatusNotifierItem::StatusNotifierItem(QSystemTrayIcon*, IconCache*) this: StatusNotifierItem(0x1aaa9b0) 
"sni-qt/31386" DEBUG 23:01:13.834 StatusNotifierItem::StatusNotifierItem(QSystemTrayIcon*, IconCache*) m_serviceName: "org.kde.StatusNotifierItem-31386-1" 
"sni-qt/31386" DEBUG 23:01:13.834 StatusNotifierItem::StatusNotifierItem(QSystemTrayIcon*, IconCache*) m_objectPath: "/StatusNotifierItem" 
"sni-qt/31386" DEBUG 23:01:13.834 virtual void StatusNotifierItem::updateMenu() menu: QMenu(0x1a79b00) 
"sni-qt/31386" DEBUG 23:01:13.840 void StatusNotifierItemFactory::registerItem(StatusNotifierItem*) 
"sni-qt/31386" DEBUG 23:01:13.841 virtual void StatusNotifierItem::updateVisibility() NewStatus( "Active" ) 
"sni-qt/31386" DEBUG 23:01:14.015 virtual void StatusNotifierItem::showMessage(const QString&, const QString&, QSystemTrayIcon::MessageIcon, int) "FlareGet Trial" "You

We just need to add more debug information like the icon name used by the application

bilelmoussaoui · 2017-01-11T22:19:29Z

@wa4557 btw bitcoin is working perfectly now! except TeamViewer and Skype, everything works as expected except the qt5 apps

andia89 · 2017-01-12T15:23:28Z

Weird. Just downloaded megasync and fixed it using the script. I don't see anything at the terminal..

bilelmoussaoui · 2017-01-12T15:48:52Z

You should use --debug

bilelmoussaoui added enhancement priority: low labels Dec 9, 2016

varlesh mentioned this issue Dec 14, 2016

How to apply "hardcode-tray" script in KDE? PapirusDevelopmentTeam/papirus-icon-theme#220

Closed

bilelmoussaoui mentioned this issue Dec 22, 2016

OpenSUSE package #251

Closed

bilelmoussaoui closed this as completed Jan 10, 2017

sni-qt improvements #243

sni-qt improvements #243

Comments

bilelmoussaoui commented Dec 9, 2016 • edited Loading

andia89 commented Dec 10, 2016

andia89 commented Dec 10, 2016

bilelmoussaoui commented Dec 10, 2016

bilelmoussaoui commented Dec 10, 2016

andia89 commented Dec 10, 2016

andia89 commented Dec 10, 2016 • edited Loading

bilelmoussaoui commented Dec 10, 2016

andia89 commented Dec 10, 2016

bilelmoussaoui commented Dec 10, 2016 via email

andia89 commented Dec 10, 2016

andia89 commented Dec 10, 2016

bilelmoussaoui commented Dec 10, 2016

andia89 commented Dec 10, 2016 • edited Loading

bilelmoussaoui commented Dec 11, 2016

andia89 commented Dec 11, 2016

andia89 commented Dec 11, 2016

bilelmoussaoui commented Dec 11, 2016

andia89 commented Dec 11, 2016

bilelmoussaoui commented Dec 11, 2016

bilelmoussaoui commented Dec 11, 2016

andia89 commented Dec 11, 2016

andia89 commented Dec 11, 2016 • edited Loading

bilelmoussaoui commented Dec 11, 2016

andia89 commented Dec 11, 2016 • edited Loading

andia89 commented Dec 11, 2016 • edited Loading

bilelmoussaoui commented Dec 11, 2016

andia89 commented Dec 11, 2016 • edited Loading

bilelmoussaoui commented Dec 11, 2016

andia89 commented Dec 13, 2016

bilelmoussaoui commented Dec 13, 2016

bilelmoussaoui commented Dec 15, 2016

KottV commented Dec 15, 2016

andia89 commented Dec 15, 2016

KottV commented Dec 15, 2016

bilelmoussaoui commented Dec 27, 2016

KottV commented Dec 28, 2016

bilelmoussaoui commented Dec 28, 2016

andia89 commented Jan 1, 2017

bilelmoussaoui commented Jan 1, 2017

andia89 commented Jan 1, 2017

bilelmoussaoui commented Jan 1, 2017

andia89 commented Jan 1, 2017

andia89 commented Jan 1, 2017

bilelmoussaoui commented Jan 1, 2017

bilelmoussaoui commented Jan 2, 2017 • edited Loading

bilelmoussaoui commented Jan 2, 2017

andia89 commented Jan 3, 2017

bilelmoussaoui commented Jan 3, 2017

bilelmoussaoui commented Jan 10, 2017

bilelmoussaoui commented Jan 10, 2017

andia89 commented Jan 11, 2017

bilelmoussaoui commented Jan 11, 2017

bilelmoussaoui commented Jan 11, 2017

andia89 commented Jan 12, 2017 • edited Loading

bilelmoussaoui commented Jan 12, 2017

bilelmoussaoui commented Dec 9, 2016 •

edited

Loading

andia89 commented Dec 10, 2016 •

edited

Loading

andia89 commented Dec 10, 2016 •

edited

Loading

andia89 commented Dec 11, 2016 •

edited

Loading

andia89 commented Dec 11, 2016 •

edited

Loading

andia89 commented Dec 11, 2016 •

edited

Loading

andia89 commented Dec 11, 2016 •

edited

Loading

bilelmoussaoui commented Jan 2, 2017 •

edited

Loading

andia89 commented Jan 12, 2017 •

edited

Loading