ownCloud Not Being Fixed

[Foggalong]

From what I understand the PPA introduced in #198 was designed to fix the problem of the patched SNI-Qt PPA not being available for 16.04 and above. I'm still having the same issue even with the new one though.

My system is Ubuntu 16.10 with XFCE Panel, and ownCloud 2.2.2 says it's being fixed by the script but remains hardcoded.

[bilelmoussaoui]

Do you have any other qt application installed ? In order to verify if it's a sin-qt issue or something else

…

Le 25 nov. 2016 à 16:24, Joshua H. Fogg ***@***.***> a écrit : From what I understand the PPA introduced in #198 was designed to fix the problem of the patched SNI-Qt PPA not being available for 16.04 and above. I'm still having the same issue even with the new one though. My system is Ubuntu 16.10 with XFCE Panel, and ownCloud 2.2.2 says it's being fixed by the script but remains hardcoded. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Foggalong]

I don't, but I'd be willing to install one to test. Recommendation?

[bilelmoussaoui]

You can try megasync

[Foggalong]

@bil-elmoussaoui Preferably something in the Ubuntu repos, though I'll try Mega if nothing else.

[bilelmoussaoui]

You can still try the old skype version, if i still remember it's on Ubuntu ppa

[varlesh]

i confirm this, new version not see megasync:

[bilelmoussaoui]

@varlesh Have you ran the script after installing megasync?

[varlesh]

of course

[varlesh]

Maybe change paths? Because icon reverted:

alex@dell:~$ hardcode-tray
[sudo] пароль для alex: 
Welcome to the tray icons hardcoder fixer!
Your indicator icon size is : 22
Your current icon theme is : Papirus-Dark-GTK
Svg to png functions are : Enabled
Applications will be fixed : All
1 - Apply
2 - Revert
Please choose: 2
Reverting now..

Clementine -- reverted
Clementine -- reverted
Google Chrome -- reverted
Guake -- reverted
Megasync -- reverted
Telegram -- reverted

Done, Thank you for using the Hardcode-Tray fixer!
alex@dell:~$ 

[varlesh]

on tmp

[bilelmoussaoui]

Those icons are already in the database, it seems that either MegaSync ships it's own version of libsni-qt or that the patch we used to use is not working anymore :(

[varlesh]

Ok, i'm now test with old version (Not json)...

[varlesh]

With old version 9aad49a worked, JSON-version very bugged.

[bilelmoussaoui]

Fixed the issue for json version, can you try again?

[varlesh]

Also for better looking need add status for changed icons, how reverted:

Clementine -- reverted
Google Chrome -- reverted
Guake -- reverted
Megasync -- reverted

Yes show progress, but i'm not see what apps changed. For example:

Clementine -- fixed
Google Chrome --  fixed
Guake --  fixed
Megasync --  fixed

[varlesh]

Mega worked with fresh git-version!

[bilelmoussaoui]

Also @Foggalong i might need to see the content of /tmp the icon names might have changed..

[bilelmoussaoui]

@Foggalong Can you show me the output of owncloud --version

[Foggalong]

@bil-elmoussaoui Will double check when I'm back with my computer, but it's just the latest version in the Ubuntu repos so I assume 2.2.2

[bilelmoussaoui]

I just installed xubuntu here, installed owncloud from the main repository.
xubuntu info

Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.1 LTS
Release:	16.04
Codename:	xenial

OwnCloud version

ownCloud version 2.1.1
Using Qt 5.5.1

Once i've installed everything, i ran OwnCloud, and the icons was ugly. I ran Hardcode-tray and i had the same result. I checked /tmp and i found those icons

I will report back if i have any news

[Daniil08]

I turned on indicators in the main settings of cinnamon and megasync started to work

[bilelmoussaoui]

@Foggalong Can you try this new PPA by @wa4557 https://code.launchpad.net/~andreas-angerer89/+archive/ubuntu/sni-qt-patched . We are going to patch sni-qt directly, and add few features in the future if possible.

[Foggalong]

Will test that sure 👍

[varlesh]

@Daniil08 i think better use another color for cinnamon tray on Arc Dark, because colors different with papirus:

sudo sed -i 's|#ffffff|#d3dae3|g' /usr/share/themes/Arc-Dark/cinnamon/cinnamon.css

[Foggalong]

Nope, still isn't working. After running the script it also seems to have unlinked my ownCloud account from the syncing app which is really weird. It really shouldn't be doing anything that can cause that :/

[andia89]

@bil-elmoussaoui Owncloud is not using sni-qt, but native QIcon. I'm not sure why it isn't fixed though, shoud be possible to theme them

[bilelmoussaoui]

It's using sni-qt as far as i know, see #56

[bilelmoussaoui]

@wa4557 In my system, gnome 3.22 with Arch linux, OwnCloud use the icon from the theme directly. So my guess, is that owncloud supports all the possible ways to create a tray icon on Linux; We just need a library as dependency in order to force OwnCloud to use sni-qt instead of QIcon

[bilelmoussaoui]

@Foggalong Qt5 dropped the support of sni-qt, and we won't be able to support those applications (at the moment). So, it's a different issue that should be opened instead of this one for Qt5 support. It seems that they use http://packages.ubuntu.com/trusty/libdbusmenu-qt5-dev to draw the tray. But no idea if they do use the same library to draw tray icons too!
I will close this and open a proper issue for Qt5

[andia89]

I want to reopen this, to keep track. Owncloud should be working (so it tries to look for a system theme icon) but isn't on most systems because it ships its own Qt version which does not find the current icon theme. I opened a bug report owncloud/client#6036 but I'm not sure this is easily fixable

[bilelmoussaoui]

Alright, even if it's an upstream issue but keeping this open will help us keep track of the upstream issue 👍

[bilelmoussaoui]

Upstream took care of the issue. Not released yet but it's already on master.