[ADAM-595] Delete the 'comparisons' code. #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means deleting the comparisons code here; these files (Comparisons, AvailableComparisons, and GeneratorFilter) are moving into the qc-metrics package, along with the ComparisonsTraversalEngine. Also being deleted are the test-suites for each of these classes. Finally, the CLI commands which use these classes, CompareADAM and FindReads, are also being deleted. Each of these classes will be moved into the qc-metrics repository as part of a separate pull request.
|
Test PASSed. |
ConcordanceTable and GenotypesSummary, as well as the concordance function from VariationRDDFunctions (in GenotypeRDDFunctions) are all being deleted, along with their tests. Also going are the GenotypeConcordance and SummarizeGenotypes commands from the CLI. All of this is being moved over to qc-metrics.
|
Test PASSed. |
|
Test FAILed. Build result: FAILUREGitHub pull request #596 of commit 4aa7af1 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/596/merge^{commit} # timeout=10Checking out Revision f260cb8edca472db9423a4964cc659f235caddd3 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f f260cb8edca472db9423a4964cc659f235caddd3 > git rev-list 329a72a # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 1.0.4,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'Test FAILed. |
|
Jenkins, retest this please. |
|
If this builds, Frank, I think it's ready to go. |
|
Test PASSed. |
fnothaft
added a commit
that referenced
this pull request
Mar 2, 2015
[ADAM-595] Delete the 'comparisons' code.
|
Let's cut it loose! Thanks @tdanford! |
|
Thanks @fnothaft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means deleting the comparisons code here; these files (Comparisons,
AvailableComparisons, and GeneratorFilter) are moving into the qc-metrics
package, along with the ComparisonsTraversalEngine.
Also being deleted are the test-suites for each of these classes.
Finally, the CLI commands which use these classes, CompareADAM and
FindReads, are also being deleted.
Each of these classes will be moved into the qc-metrics repository as
part of a separate pull request.
This resolves #595