-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the 'comparisons' code into a separate repository. #595
Comments
+1 |
Will you move the variant concordance work into qc-metrics as well? |
Where is that? |
The big ones that I'm aware of are:
It's not all of |
Yeah, I'll move those. One sec. (I'm building up a corresponding branch in qc-metrics as I go, of course.) |
Sounds awesome; looking forward to it! |
While I'm working on this (and I've got kid duty today, so it's intermittent) can you open up an issue or two, for any other major chunks of code like this that you think need to be moved to another repo too? |
YGI, will do after brunch. |
Thx. |
As part of our attempt to slim down the core
adam
module into its minimal set of classes, and also as preparation for re-writing some of the Picard-style metrics (this is relevant to the NCI Cloud Pilot project), we should move out all the core code and commands which compute read- and variant-level metrics from the adam-core module into a separate module and repository.This repository (qc-metrics) has already been created. This issue is for deleting the code (in org.bdgenomics.adam.metrics), the ComparisonTraversalEngine class, all their test suites, and the two commands (FindReads and CompareADAM) which depend on them.
All of this will be re-created in the qc-metrics repository.
The text was updated successfully, but these errors were encountered: