Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the 'comparisons' code into a separate repository. #595

Closed
tdanford opened this issue Mar 1, 2015 · 9 comments · Fixed by #596
Closed

Move the 'comparisons' code into a separate repository. #595

tdanford opened this issue Mar 1, 2015 · 9 comments · Fixed by #596
Assignees
Milestone

Comments

@tdanford
Copy link
Contributor

tdanford commented Mar 1, 2015

As part of our attempt to slim down the core adam module into its minimal set of classes, and also as preparation for re-writing some of the Picard-style metrics (this is relevant to the NCI Cloud Pilot project), we should move out all the core code and commands which compute read- and variant-level metrics from the adam-core module into a separate module and repository.

This repository (qc-metrics) has already been created. This issue is for deleting the code (in org.bdgenomics.adam.metrics), the ComparisonTraversalEngine class, all their test suites, and the two commands (FindReads and CompareADAM) which depend on them.

All of this will be re-created in the qc-metrics repository.

@tdanford tdanford self-assigned this Mar 1, 2015
@fnothaft
Copy link
Member

fnothaft commented Mar 1, 2015

+1

@fnothaft
Copy link
Member

fnothaft commented Mar 1, 2015

Will you move the variant concordance work into qc-metrics as well?

@tdanford
Copy link
Contributor Author

tdanford commented Mar 1, 2015

Where is that?

@fnothaft
Copy link
Member

fnothaft commented Mar 1, 2015

@tdanford
Copy link
Contributor Author

tdanford commented Mar 1, 2015

Yeah, I'll move those. One sec. (I'm building up a corresponding branch in qc-metrics as I go, of course.)

@fnothaft
Copy link
Member

fnothaft commented Mar 1, 2015

Sounds awesome; looking forward to it!

@tdanford
Copy link
Contributor Author

tdanford commented Mar 1, 2015

While I'm working on this (and I've got kid duty today, so it's intermittent) can you open up an issue or two, for any other major chunks of code like this that you think need to be moved to another repo too?

@tdanford tdanford changed the title Move the 'Comparisons' code into a separate repository. Move the 'comparisons' code into a separate repository. Mar 1, 2015
@fnothaft
Copy link
Member

fnothaft commented Mar 1, 2015

YGI, will do after brunch.

@fnothaft fnothaft added this to the 0.17.0 milestone Mar 1, 2015
@tdanford
Copy link
Contributor Author

tdanford commented Mar 1, 2015

Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants