-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Clarify that EDF/BDF files MUST have lower case extensions in BIDS #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sappelhoff
changed the title
Fix EDF spec to require lower-case extension
[FIX] Clarify that European data format Nov 12, 2021
.edf
files MUST have lower case extension in BIDS
sappelhoff
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Adam!
effigies
reviewed
Nov 12, 2021
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
sappelhoff
reviewed
Nov 14, 2021
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
sappelhoff
approved these changes
Nov 14, 2021
effigies
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a very small fix for a typo and some misaligned table fences.
This LGTM. Thanks!
effigies
changed the title
[FIX] Clarify that European data format
[FIX] Clarify that EDF/BDF files MUST have lower case extensions in BIDS
Nov 15, 2021
.edf
files MUST have lower case extension in BIDS
effigies
added a commit
to effigies/bids-specification
that referenced
this pull request
Nov 17, 2021
…IDS (bids-standard#927) * Fix EDF spec * drop latin, use 'lower case' without dash - * Update src/04-modality-specific-files/03-electroencephalography.md Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Convert to table * Format table * add missing dots Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com> * add missing code formatting, one consistency fix * Fix reviews * STY: Fix typo, table fences Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> Co-authored-by: Chris Markiewicz <effigies@gmail.com> Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com> Co-authored-by: Christopher J. Markiewicz <markiewicz@stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/bids-standard/bids-validator/pull/1381, we now clarify that the EDF files should be lower-case extension.