Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add CBV and phase to Entity table #312

Merged
merged 6 commits into from
Aug 20, 2019

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 16, 2019

Closes #311. Adds the functional MRI modalities CBV and phase to the Entity table. Also fixes a couple of minor typos in the MRI specification page.

@tsalo tsalo requested a review from chrisgorgo as a code owner August 16, 2019 17:46
@effigies
Copy link
Collaborator

Thanks @tsalo. Apparently the pipes are now out of alignment. Can you remove ten spaces to make up for the ten characters you added?

…ata.md

Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
@tsalo
Copy link
Member Author

tsalo commented Aug 16, 2019

@effigies Thanks! It should be fixed now.

effigies
effigies previously approved these changes Aug 16, 2019
oesteban
oesteban previously approved these changes Aug 17, 2019
Copy link
Collaborator

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the stylistic comment of not breaking a line after only one word.

…ata.md

Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
@tsalo tsalo dismissed stale reviews from oesteban, franklin-feingold, and effigies via 0cff773 August 17, 2019 13:07
…ata.md

Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
@tsalo
Copy link
Member Author

tsalo commented Aug 17, 2019

@effigies do you know if bids-validator is regularly updated based on changes to the specification, or should I open an issue about supporting phase data on that repository?

@effigies
Copy link
Collaborator

In theory it should, but if it's not detecting something, please open issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional modalities CBV and phase are not represented in Entity table
5 participants