-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]v0 for spm parser #50
Conversation
@cmaumet Here is what I get when I run python bids_prov/spm_parser.py examples/spm_default/batch.m -o test.json && python bids_prov/visualize.py test.json && open test.png |
Discussed w/ @remiadon on Feb 8, next steps include:
|
Here is what I get after f094136 |
Thanks @remiadon! I did not see anything specific but in general I think all activities should have a "used" relationship and this does not seem to be the case in the graph above. Can you have a look? |
Oh I see there is a buggy part : "file(1)_4" and "file(1)_3" should not be chained ... |
and here is what I get for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @remiadon, thanks for this.
One quick note on your latest graph:
- the links between the entities and the SPM software should be removed (to only retain the links between the activities and the software).
Once this is done, I am happy to merge this. For the next sprint, here are a few things we should look at to improve this example:
file_move_2
has no wasGeneratedBy link. Do you think there could be a confusion with the output of file_move_1?- in the name of the Activity could we keep everything after "spm.", for example "preproc._7" would become "spatial.preproc._7"
- To make the graph easier to read, is there an option to hide identifiers?
And in 434eeaf I fixed activity names :) A limit is left to 30 characters for activity names, otherwise I find it quite verbose |
Ok let's merge and we'll keep the other items for the next iteration! |
@cmaumet I tried to fix what you mentionned about "file_move_2" by linking dependencies in another manner Here is the graph I get I do think it's way better, what do you think ? |
Yes! There is one remaining missing link : "fmri_spec" used "Smoothed images" |
@cmaumet ready to merge |
This PR tries to introduce a parser for SPM, i.e a piece of program that takes
.m
files as those available to SPM users and produces the corresponding BIDSprov graph, in jsonld