-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validator module #2
Comments
@remiadon: +1 for the validator. Because the model will be BIDS-compatible, it would be useful to build of the BIDS validator: https://github.com/bids-standard/bids-validator For a demo see here: https://bids-standard.github.io/bids-validator/ The BIDS validator is very consistent in spirit with what you described except that it takes a BIDS folder as input (and not only the json file). |
@cmaumet I'm not sure to understand. Should we make PRs to the repo you mentionned or provide something in the same spirit ? |
Once we'll have the spec ready, it will be a PR to the repo. |
EDIT : pySHACL seems to be a good place to start |
Yes for RDF validation. |
@remiadon: I beleive this issue should be removed from "sprint 2", are you fine with that? |
@cmaumet yep I'll save this for later |
Great! Can you update https://github.com/Inria-Visages/BIDS-prov/projects/1 accordingly? |
Like discussed we will use a shacl file later in the project to tackle this. |
Yes and this will have to live in the BIDS validator. I would say let's leave it aside for now as we focus on the spec and the examples. |
edit : a CI script to check parsing from SPM is required in #50 A validator module would be awesome so that CI does the following:
|
One thing we might want to do at some point in providing a provenance framework is providing a validator for it
If an institution or a user creates prov files, we should provide them a program to check the validity of those files within the framework
This program should :
In other words running this program acts as a sanity check.
For warnings and errors, a way would be to use the python
logging
module, but that looks a bit tedious for that. For a V1 I think we can use thewarnings
module, and raise a warning if anything looks non-valid, and just return False in any other situationThe text was updated successfully, but these errors were encountered: