Add trace ray ground Lua functions #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loveridge
approved these changes
Nov 2, 2024
saurtron
added
the
candidate
saurtron
force-pushed
the
trace-ray-ground
branch
from
8f6de20 to
a16c426
Compare
|
rebased |
saurtron
removed
the
candidate
|
oops added some comments before that were actually for #1624 sorry, so many traceray PRs XD will test this one soon too |
saurtron
added
the
candidate
saurtron
added a commit
to saurtron/Beyond-All-Reason
that referenced
this pull request
Dec 16, 2024
saurtron
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Added a small nipick, otherwise I found this to work fine.
Created the following widget to test: dbg_gui_test_ground_rays.lua
- Start skirmish
- Enable widget "TestRays Ground"
- Click somewhere, you will get:
- echo of ground intersection
- echo of water intersection
- also calculate ground intersection with raybetween to see it gives the same result
- do ray between first two selected units and send the first to attack ground the found position with some offsets in y so its likely to find the middle point
- if not nselected == 2, then it will just get the first unit from AllUnits, and do a ray intersection to the clicked point, offseting ground.y +10, and unit.y -10, send it there to attack ground.
- tells you the water depth inferred from both water and ground rays
saurtron
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1624.
Depends on #1705.