Add TraceRay Lua Functions #1624

12345swordy · 2024-07-31T03:03:25Z

Or Rather Finished the implementation of Lua functions that deemed relevant.

loveridge

Code looks good, but I didn't test it

loveridge · 2024-07-31T04:06:39Z

rts/Lua/LuaSyncedRead.cpp

@@ -39,6 +39,7 @@
 #include "Sim/Misc/QuadField.h"
 #include "Sim/Misc/TeamHandler.h"
 #include "Sim/Misc/Wind.h"
+#include "Sim//Misc/CollisionHandler.h"


two slashes

loveridge · 2024-07-31T04:07:27Z

rts/Lua/LuaSyncedRead.cpp

+
+int LuaSyncedRead::TraceRayUnits(lua_State* L) //returns the list of units that an raytrace has hit
+{
+	float3 pos((double)luaL_checknumber(L, 1), (double)luaL_checknumber(L, 2), (double)luaL_checknumber(L, 3));


there is a luaL_checkfloat

loveridge · 2024-07-31T04:15:35Z

rts/Lua/LuaSyncedRead.cpp

+ */
+int LuaSyncedRead::TraceRayFeatures(lua_State* L) //returns the list of features that an raytrace has hit
+{
+	 float3 pos((double)luaL_checknumber(L, 1), (double)luaL_checknumber(L, 2), (double)luaL_checknumber(L, 3));


there is an extra space at the start of these lines

loveridge · 2024-07-31T04:25:10Z

rts/Lua/LuaSyncedRead.cpp

+ */
+int LuaSyncedRead::TraceRayGround(lua_State* L)
+{
+	 float3 pos((double)luaL_checknumber(L, 1), (double)luaL_checknumber(L, 2), (double)luaL_checknumber(L, 3));


an extra space on the start of these lines too

loveridge · 2024-07-31T04:28:40Z

rts/Lua/LuaSyncedRead.cpp

+ * @number dirY
+ * @number dirZ
+ * @number traceLength
+ * @treturn {{len, Id},...}


return type for doc wrong

sprunk · 2024-07-31T11:30:38Z

rts/Lua/LuaSyncedRead.cpp

+	for (const int quadIdx : *qfQuery.quads) {
+		const CQuadField::Quad& quad = quadField.GetQuad(quadIdx);
+
+		for (CUnit* u : quad.units) {


It would be good if the returned list was sorted in order of distance, from the closest.

Can you not reverse it in lua?

sprunk · 2024-07-31T11:31:47Z

rts/Lua/LuaSyncedRead.cpp

+	 if (traceLength > groundLength && groundLength > 0.0f) {
+		 traceLength = groundLength;
+	 }


If the ray fails to intersect ground the function should probably return nil.

12345swordy · 2024-07-31T18:10:47Z

ping @sprunk

rts/Lua/LuaSyncedRead.cpp

…et it to follow LOS rules.

rts/Lua/LuaSyncedRead.cpp

sprunk · 2024-09-29T13:40:43Z

I found some time to spare and extracted the ground traceray to a separate PR after some finishing touches #1706.

12345swordy · 2024-10-02T17:14:36Z

What should I do regarding the other two functions then? TraceRayUnits and TraceRayFeatures specifically?

sprunk · 2024-10-02T17:47:52Z

For now the only task is to test them, I'll do that when I have some more free time.

saurtron · 2024-12-16T18:01:20Z

Regarding my test of this branch, imo needs some work since it's pretty awkward to work with, and has the classic bug regarding radar dots too.

My concerns:

Forces you to add posx, posy, posz, dirx, diry, dirz, distance
Not sure there's even a way to get mouse->dir or Farplane dist (the usual things to put there)
- for the test widget I was going to do it in Update(), but just found a way to get mouse dir for "GetMouseStartPosition", that one asks for a mouse button
- imo these should be autocalculated to CameraPos + mouse->dir as it's the most usual if not adding anything there
- length should default to farplane for groundray, or usual groundtrace + SelectThroughGround for units or features queries when not setting it
The quadray tracing is not aware of radar dots, as usual, should implement wideray as needed at least if enabling radar use (either it should always do it, or have a flag to do_radar or not)
Returns duplicates for features and units, imo this should be avoided since it's easier to remove the duplicates from c++ than lua
Maybe a flag to just get the closest one could be in order too, since most times that's what ppl will want I guess, in that case it would just need to return an unitID/featureID
- that's also going to be very expensive and lots of repeated code everywhere from lua if we don't facilitate

saurtron · 2024-12-16T18:01:24Z

Hey, created a test widget for this: dbg_gui_test_rays.lua.

Put in your Widgets dir
Start skirmish
Enable widget "TestRays"
Click in different places with any mouse button
- the widget will Echo what was traced by the ray (units, features or ground in that order, if units gets found then it doesnt go on, and so on)

sprunk · 2024-12-17T03:44:46Z

mouse->dir or Farplane dist (the usual things to put there)
not aware of radar dots
forces you to add posx, posy, posz, dirx, diry, dirz, distance

This is for mechanics like chain lightning so none of these is applicable.

Returns duplicates

Sounds bad.

Maybe a flag to just get the closest one could be in order too

Perhaps input n and make it return the n closest?

Add TraceRay Lua Functions

a53c5c7

loveridge reviewed Jul 31, 2024

View reviewed changes

sprunk reviewed Jul 31, 2024

View reviewed changes

Makes changes due to feedback.

b36d7df

sprunk reviewed Jul 31, 2024

View reviewed changes

rts/Lua/LuaSyncedRead.cpp Outdated Show resolved Hide resolved

Fix minor bug

5f0ba39

sprunk reviewed Aug 6, 2024

View reviewed changes

rts/Lua/LuaSyncedRead.cpp Show resolved Hide resolved

12345swordy added 2 commits August 7, 2024 10:09

Added optional ignore water as parameter for TraceRayGround. Try to g…

50c73b7

…et it to follow LOS rules.

Add pos values as requested

cc63c0a

sprunk reviewed Aug 10, 2024

View reviewed changes

rts/Lua/LuaSyncedRead.cpp Outdated Show resolved Hide resolved

Normalize Direction Vector

0471757

sprunk reviewed Aug 10, 2024

View reviewed changes

rts/Lua/LuaSyncedRead.cpp Outdated Show resolved Hide resolved

rts/Lua/LuaSyncedRead.cpp Outdated Show resolved Hide resolved

rts/Lua/LuaSyncedRead.cpp Outdated Show resolved Hide resolved

rts/Lua/LuaSyncedRead.cpp Outdated Show resolved Hide resolved

12345swordy added 2 commits August 10, 2024 17:09

Make changes based on sprunk feedback.

788d677

Forgot changes regarding waterRayLength

3ca29e6

sprunk mentioned this pull request Sep 29, 2024

Add trace ray ground Lua functions #1706

Merged

saurtron added the area: Lua API label Dec 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add TraceRay Lua Functions #1624

Add TraceRay Lua Functions #1624

12345swordy commented Jul 31, 2024

loveridge left a comment

loveridge Jul 31, 2024

loveridge Jul 31, 2024

loveridge Jul 31, 2024

loveridge Jul 31, 2024

loveridge Jul 31, 2024

sprunk Jul 31, 2024

12345swordy Jul 31, 2024

sprunk Jul 31, 2024

12345swordy commented Jul 31, 2024

sprunk commented Sep 29, 2024

12345swordy commented Oct 2, 2024

sprunk commented Oct 2, 2024

saurtron commented Dec 16, 2024

saurtron commented Dec 16, 2024

sprunk commented Dec 17, 2024

Add TraceRay Lua Functions #1624

Are you sure you want to change the base?

Add TraceRay Lua Functions #1624

Conversation

12345swordy commented Jul 31, 2024

loveridge left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

12345swordy commented Jul 31, 2024

sprunk commented Sep 29, 2024

12345swordy commented Oct 2, 2024

sprunk commented Oct 2, 2024

saurtron commented Dec 16, 2024

saurtron commented Dec 16, 2024

sprunk commented Dec 17, 2024