Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cone and Cylinder shapes to bevy_render::mesh::shape #3456

Closed
nicopap opened this issue Dec 28, 2021 · 1 comment
Closed

Add Cone and Cylinder shapes to bevy_render::mesh::shape #3456

nicopap opened this issue Dec 28, 2021 · 1 comment
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible

Comments

@nicopap
Copy link
Contributor

nicopap commented Dec 28, 2021

What problem does it solve

I plan to create a debug shape bevy plugin. It would simply just spawns meshes with a special line drawing shader. But currently the default mesh library in bevy is very limited, I would have to implement separately a few of even the most basic shapes! The Bevy shape module misses such basic shapes as a cylinder or cone.

What solution would you like?

I already have working implementation of algorithms to compute cylinder and cone vertices and edges (in the heron debug view implementation)

I only suggest that I personally port those to the bevy shape module. But I first want to know if the addition is welcome, so that it doesn't turn into wasted efforts.

What alternative(s) have you considered?

The other solution is simply that everyone copy the cylinder and cone mesh generation algorithms when they need it. For me it's not a problem given I already did this. But I don't see why the torus gets a pass and not cylinders!

Additional context

Future additions could include a rounded cuboid or arbitrary convex vertex collections. But that's not on the radar currently.

@nicopap nicopap added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Dec 28, 2021
@mockersf mockersf added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Dec 29, 2021
@mockersf
Copy link
Member

there has been a lot of discutions around shapes in bevyengine/rfcs#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible
Projects
None yet
Development

No branches or pull requests

2 participants