Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we use the darling crate for proc macros #17497

Open
Bleachfuel opened this issue Jan 22, 2025 · 0 comments
Open

Should we use the darling crate for proc macros #17497

Bleachfuel opened this issue Jan 22, 2025 · 0 comments
Labels
A-Cross-Cutting Impacts the entire engine C-Code-Quality A section of code that is hard to understand or change D-Macros Code that generates Rust code D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Design This issue requires design work to think about how it would best be accomplished

Comments

@Bleachfuel
Copy link
Contributor

Bleachfuel commented Jan 22, 2025 •
edited
Loading

While writing #17496 I came upon a crate called darling which would really simplify all proc macros we currently have such as AsBindGroup. It would be way easier to specify attributes and they would be real structs instead of const structs. We would also get the benefit of spelling suggestions.
@BenjaminBrienen BenjaminBrienen added C-Code-Quality A section of code that is hard to understand or change S-Needs-Design This issue requires design work to think about how it would best be accomplished A-Cross-Cutting Impacts the entire engine D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes D-Macros Code that generates Rust code labels Jan 23, 2025
@Bleachfuel Bleachfuel changed the title Should we use the deluxe crate for proc macros Should we use the darling crate for proc macros Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Cross-Cutting Impacts the entire engine C-Code-Quality A section of code that is hard to understand or change D-Macros Code that generates Rust code D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Design This issue requires design work to think about how it would best be accomplished
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenjaminBrienen @Bleachfuel