Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid internal system ambiguities when using DefaultPlugins in CI #10416

Closed
alice-i-cecile opened this issue Nov 6, 2023 · 3 comments
Closed

Forbid internal system ambiguities when using DefaultPlugins in CI #10416

alice-i-cecile opened this issue Nov 6, 2023 · 3 comments
Labels
A-Build-System Related to build systems or continuous integration A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior

Comments

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Nov 6, 2023 •
edited
Loading

What problem does this solve or what need does it fill?

Bevy-internal system order ambiguities are bad because:

  1. They're often the source of real bugs.
  2. They badly pollute end-user diagnostics.

What solution would you like?

Add an integration test which adds all default plugins, checks for ambiguities and then panics if there are any.

Ideally this is run with all features enabled.

Additional context

Discussed in:
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events A-Build-System Related to build systems or continuous integration labels Nov 6, 2023
@alice-i-cecile
Copy link
Member Author

Done in bevy_xpbd by @johanhelsing in Jondolf/avian#230

@BD103
Copy link
Member

BD103 commented Mar 21, 2024

Similar (or maybe a duplicate? I can't tell): #7386

@alice-i-cecile
Copy link
Member Author

Yep, duplicate.

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alice-i-cecile @BD103