Ajout de la page de récap d'habilitation #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tut-tuuut
reviewed
Feb 8, 2022
tut-tuuut
reviewed
Feb 8, 2022
tut-tuuut
reviewed
Feb 8, 2022
tut-tuuut
suggested changes
Feb 8, 2022
christophehenry
force-pushed
the
recap-page
branch
from
0398ed1
to
af92470
Compare
christophehenry
commented
Feb 8, 2022
Comment on lines
+161
to
+180
| def __init__(self, **kwags): | ||
| kwags.setdefault("error_class", PatchedErrorList) | ||
| super().__init__(**kwags) |
There was a problem hiding this comment.
@tut-tuuut Alors attention, je viens de me faire avoir : cette méthode marche bien mais elle rend impossible de passer les argument positionnellement.
christophehenry
force-pushed
the
recap-page
branch
from
af92470
to
9c34718
Compare
|
Je garde la fonctionnalité de vérification d'email dans une PR séparée parce que celle-ci est déjà bien fat. |
christophehenry
force-pushed
the
recap-page
branch
from
9c34718
to
e4dc0c7
Compare
Et ça n'a rien à voir de toute façon. :) Donc OK |
tut-tuuut
reviewed
Feb 8, 2022
| cleaned_data, | ||
| ) | ||
|
|
||
| self.assertRedirects(response, reverse("habilitation_new_issuer")) |
There was a problem hiding this comment.
Je pense qu'on reverra ce comportement, ça me semble plus logique de proposer une autre demande pour le même demandeur. Pour l'instant on laisse.
There was a problem hiding this comment.
Ça changera quanf j'aurais implémenté la page suivante.
tut-tuuut
approved these changes
Feb 8, 2022
Co-authored-by: Agnès Haasser <1035145+tut-tuuut@users.noreply.github.com>
christophehenry
force-pushed
the
recap-page
branch
from
e4dc0c7
to
5b958dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖼️ Images