Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

feat(DropdownMenu): handle variant prop #144

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

Silver343
Copy link

πŸ”— Linked issue

nuxt#2146

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Cleaner version of #142.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac
Copy link
Owner

benjamincanac commented Jul 22, 2024

I'm not sure to understand why classes are not picked up for subtle variant πŸ€”

@Silver343
Copy link
Author

Silver343 commented Jul 22, 2024

@benjamincanac can you provide more details.

seems to be working for me.

image

@benjamincanac
Copy link
Owner

benjamincanac commented Jul 24, 2024

The divider should not be black (same in dark mode but white) and the hover states don't seem to work 😬

@Silver343
Copy link
Author

it seems the current divider color is the browser default and the divide-gray-300 is not making it to the browser, this is the case if i change other components too. not sure how the tailwind jit works with the nuxt module and template file used.

@Silver343
Copy link
Author

it seems to be related to a dependency, when I switch to a outdated branch and install the dependancies then switch back it looks as expected and i can update it with new classes.

The hover isn't correct at the moment as the hover class and the bg class are the same color. Ive corrected for the screenshot below.

image

if I update the dependencies. it breaks as soon as i updated any class in the theme.

The last commit in the branch that works is e7e1b23

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants