Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DropdownMenu/ContextMenu/InputMenu/Select/SelectMenu] Handle color and size to match buttons #2146

Closed
5 of 10 tasks
benjamincanac opened this issue Apr 5, 2024 · 6 comments · Fixed by benjamincanac/ui3#125
Closed
5 of 10 tasks

[DropdownMenu/ContextMenu/InputMenu/Select/SelectMenu] Handle color and size to match buttons #2146

benjamincanac opened this issue Apr 5, 2024 · 6 comments · Fixed by benjamincanac/ui3#125
Labels
enhancement New feature or request v3 #1289

Comments

@benjamincanac
Copy link
Member

benjamincanac commented Apr 5, 2024 •
edited
Loading

Size

  • DropdownMenu
  • ContextMenu
  • InputMenu
  • Select
  • SelectMenu

Color

  • DropdownMenu
  • ContextMenu
  • InputMenu
  • Select
  • SelectMenu
@benjamincanac benjamincanac added the enhancement New feature or request label Apr 5, 2024
@Silver343
Copy link
Contributor

were you thinking size and colour for the trigger and/or the items?

@benjamincanac
Copy link
Member Author

No for the menu, you can put anything you like in the trigger but most of the time you will use a UButton. We should be able to handle two colors, white and gray (which was the default in the previous version).

@benjamincanac benjamincanac changed the title [DropdownMenu] Handle color and size to match buttons [DropdownMenu/ContextMenu] Handle color and size to match buttons Jun 11, 2024
@Silver343 Silver343 mentioned this issue Jun 11, 2024
Merged
8 tasks
@benjamincanac benjamincanac changed the title [DropdownMenu/ContextMenu] Handle color and size to match buttons [DropdownMenu/ContextMenu/InputMenu/Select/SelectMenu] Handle color and size to match buttons Jun 19, 2024
@benjamincanac benjamincanac reopened this Jun 19, 2024
This was referenced Jun 25, 2024
Merged
Merged
@sandros94 sandros94 mentioned this issue Jul 1, 2024
Merged
8 tasks
This was referenced Jul 7, 2024
Closed
Open
@benjamincanac benjamincanac added the v3 #1289 label Jul 18, 2024
@benjamincanac benjamincanac transferred this issue from benjamincanac/ui3 Sep 6, 2024
@benjamincanac Volta.net
Copy link
Member Author

@Silver343 Sorry I completely lost your PR when I moved the code from benjamincanac/ui3 to nuxt/ui. Would you still be interested in implementing the color prop?

@Silver343
Copy link
Contributor

@benjamincanac No problem. Looks like the color prop is already implemented in the InputMenu, Select and SelectMenu. Not sure it is neccassry for the DropwDownMenu or ContextMenu

@Silver343
Copy link
Contributor

just saw #2339 which makes sense.

@benjamincanac Volta.net
Copy link
Member Author

Indeed! Let's close this then 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(DropdownMenu): handle size prop Silver343/ui3
2 participants
@benjamincanac @Silver343